Produits Entr'ouvert » Authentic 2 » Plugin FS FranceConnect

I would add data.raise_for_status(allow_redirects=False) after the line data = self.oauth_session.... to also handle such errors as HTTP (3xx, 4xx, 5xx). Also I don't know if catching SSLError after RequestException would work as SSLError is a child class of RequestException¹.

¹

class RequestException(RuntimeError):
    """There was an ambiguous exception that occurred while handling your
    request.""" 

class HTTPError(RequestException):
    """An HTTP error occurred.""" 
    response = None

class ConnectionError(RequestException):
    """A Connection error occurred.""" 

class SSLError(ConnectionError):                                                                                                                                                
    """An SSL error occurred.""" 

>>> class A(Exception):
...    pass
... 
>>> try:
...    raise A
... except Exception:
...    print 'E'
... except A:
...    print 'A'
... 
E

Mikaël Ates a écrit :

Ok for adding data.raise_for_status and I added to the get arguments allow_redirects=False, timeout=3.

For the exceptions, it is strange since I've tested for the access token request with the same error catching statements and I grab the SSL error :

[...]

[...]

"unable to retrieve access token" is the string returned by the first catch block, exactly like I said.

I think the allow_redirects=False must be set on the raise_for_status() too but you can allow it on the get() (it's allowed by default I think).

Ok for raise_for_status() I must have checked on an older version of raise_for_status() and the API has moved. Ack.