Bug #10019: Setting a signature algorithm to a SHA greater than 1 fails - Lasso - Redmine Entr’ouvert

Bug #10019

Setting a signature algorithm to a SHA greater than 1 fails

Ajouté par Brett Gardner il y a environ 8 ans. Mis à jour il y a environ 8 ans.

Statut:

Fermé

Priorité:

Normal

Assigné à:

Catégorie:

SAMLv2

Version cible:

2.5.1

Début:

18 février 2016

Echéance:

% réalisé:

100%

Temps estimé:

Patch proposed:

Oui

Planning:

Description

If you set the signature method to a SHA256, SHA384 or SHA512 the signature created is invalid. Eg (php)

$sp_server = new LassoServer($xml,$key,NULL,$crt); LassoServer_signatureMethod_set($sp_server->_cptr,LASSO_SIGNATURE_METHOD_RSA_SHA256);

Also note, that there is a bug in the lasso.php file that is shipped / generated whereby you have to set the signature method as above, if you attempt to do the following it fails as the "LassoServer::set_signaturemethod" is expecting a Lasso object instead of a constant. Note this may be incorrect usage by myself.

$sp_server->signatureMethod = LASSO_SIGNATURE_METHOD_RSA_SHA256;

Attached is a patch that corrects this behaviour. However I do not have a reproduce case

This may be related to bug #9479

Fichiers

lasso-2.5.0-fix-sha256.patch (3,12 ko) lasso-2.5.0-fix-sha256.patch

Brett Gardner, 18 février 2016 05:43

Demandes liées

Révisions associées

Révision 74e8705b (diff)
Ajouté par Benjamin Dauvergne il y a environ 8 ans

tools.c: use correct NID and digest length when building RSA signature using SHA-2 digest (fixes #10019)

Thanks to Brett Gardner for the bug report and patch.

Licence: MIT

Historique

Mis à jour par Benjamin Dauvergne il y a environ 8 ans

Looks good, thank your. I'll see to integrate your patch today or tomorrow, could you send a mail to our mailing list stating that your contributin to lasso will be under the MIT license please ? It's our contributor agreement. Or you can send it directly to support@entrouvert.com. Thank you.