Project

General

Profile

Development #10322

Remove title from profile frontends.

Added by Mikaël Ates almost 4 years ago. Updated over 3 years ago.

Status:
Nouveau
Priority:
Normal
Assignee:
-
Category:
-
Target version:
2.2.0
Start date:
16 Mar 2016
Due date:
% Done:

0%

Patch proposed:
No
Planning:
No

Description

Some themes reuse the profile frontend but have a different hierarchy of titles. We may remove the title from profile frontends and let templates define titles, that may be the frontend name.

One patch to pass the fontend name with the block in blocks_by_id. (blocks_by_id was introduced in commit 7b633fe71f0e3ac3bd588b955662bf54e355ed37 and is not used yet.)

One for the authentic2 account template.

One of the FC Plugin that presents the modification required on every frontend (list to be defined) i.e. remove the title and check there's a name.

And the modification of the patch proposed in #8840.

0001-Define-profile-frontends-titles-in-account-template.patch View (1.03 KB) Mikaël Ates, 16 Mar 2016 04:02 PM

0001-Remove-title-from-auth_ssl-profile-frontend.patch View (949 Bytes) Mikaël Ates, 21 Mar 2016 12:59 PM

0001-Remove-title-from-password-profile-frontend.patch View (899 Bytes) Mikaël Ates, 21 Mar 2016 12:59 PM

History

#1 Updated by Mikaël Ates almost 4 years ago

  • Description updated (diff)

#2 Updated by Mikaël Ates almost 4 years ago

  • Description updated (diff)

#3 Updated by Mikaël Ates almost 4 years ago

We could do that in two steps :

  • step 1 : Patch 1, 3 et 4 of the list
  • step 2 : Check there's a name and remove titles in all frontends et Patch 2

#4 Updated by Benjamin Dauvergne almost 4 years ago

Ack for all, wait for patch 4 when montpellier theme is ok, and rebase without MSP.

#5 Updated by Benjamin Dauvergne almost 4 years ago

Push only 1 in authentic, then wait for review of all authentication frontends (for removal of header tag from their profile block).

#6 Updated by Mikaël Ates almost 4 years ago

Patches 1 and 3 pushed.

New patches to remove titles form auth_ssl and password profile frontends.

#7 Updated by Benjamin Dauvergne almost 4 years ago

Ack. Could you add ticket numbers in your commit messages ? (#xxxxx)

#8 Updated by Benjamin Dauvergne almost 4 years ago

Also please merge the following commits together (would be simpler if they did not have all the same number :) ),
  • define profiles frontends title
  • all "remove title from" commits

#9 Updated by Mikaël Ates over 3 years ago

  • Tracker changed from Bug to Development
  • Target version set to 2.2.0

#10 Updated by Mikaël Ates over 3 years ago

  • File deleted (0001-Add-frontend-name-to-blocks_by_id.patch)

#11 Updated by Mikaël Ates over 3 years ago

The patch 0001-Add-frontend-name-to-blocks_by_id.patch was introduced in commit 8db04ed7cc3c41800815bb462d67691a868d1195

#12 Updated by Mikaël Ates over 3 years ago

  • File deleted (0001-Remove-title-from-profile-frontend.patch)

#13 Updated by Mikaël Ates over 3 years ago

The patch 0001-Remove-title-from-profile-frontend.patch is pushed in authentic2-auth-fc.

#14 Updated by Mikaël Ates over 3 years ago

  • File deleted (0001-Display-block-by-their-id-in-account-management.patch)

#15 Updated by Mikaël Ates over 3 years ago

The patch 0001-Display-block-by-their-id-in-account-management.patch was introduced in commit 87bc37e6f971051ea898298d50ac06f36920c588 of montpellier-theme.

Also available in: Atom PDF