Produits Entr'ouvert » Authentic 2

Seul le thème montpellier utilise un thème différent pour registration_form.html et utilise les frontaux d'enregistrements des plugins. Le patch serait le suivant :

diff --git a/templates/registration/registration_form.html b/templates/registration/registration_form.html
index 33dccf3..06b6868 100644
--- a/templates/registration/registration_form.html
+++ b/templates/registration/registration_form.html
@@ -11,13 +11,13 @@
 </div>

 <div class="right">
-{% include 'authentic2/form.html' with form=form %}
-{% for registration_frontend in registration_frontends %}
+  {% include 'authentic2/form.html' with form=form %}
+  {% if frontends.fc %}
     <div class="textbreak"><span>OU</span></div>
-    {{ registration_frontend|safe }}
-{% endfor %}
+    <h2>{{ frontends.fc.name }}</h2>
+    {{ frontends.fc.content|safe }}
+  {% endif %}
 </div>

 <br class="clear"/>
-
 {% endblock %}
(END)

The proposition breaks the compatibility with plugins but as far as I know, registration frontend management is for now only used with the FC plugin.

It's also used for the belgian eid authentication (https://git.entrouvert.org/authentic2-auth-fedict.git/).

{% for id, block in frontends.items %}
    <br/>
    <h2>{{ block.name }}</h2>
    {{ block.content|safe }}
{% endfor %}

I wouldn't add <br> to the markup, but I would enclose title/content in a <div class="whatever">.

             if hasattr(frontend.name, '__call__'):

Use callable(). ?

            blocks.append({
                    'id': frontend.id(),
                    'name': frontend.name,
                    'content': response.content,
                    'frontend': frontend,
            })

Reading get_backends it allow .id not to be a callable, this is lost here. Maybe get_backends() could be changed to add a new attribute with the appropriate id instead of relying on callers to duplicate the work?

            response = frontend.registration(self.request, context_instance=request_context)
            if not response or response.status_code != 200:

I understand the convenience of shortcut functions (like django.shortcuts.render) but this feels wrong to rely on HttpResponse here.

Concerning the belgian eid authentication plugin there is no concern since no registration_frontend method is defined on the plugin.

Ack.

And... it broke the authentic2-auth-fedict.

Defining the Frontend id with an attribute or a method should not be a problem. Could you explain a little bit more ?

Hum, I see it.

I extended the practice

if hasattr(frontend.name, '__call__'):
    frontend.name = frontend.name()

Maybe get_backends() could be changed to add a new attribute with the appropriate id instead of relying on callers to duplicate the work?

So we could go back and let callers check those attributes. Or we could move plugins towards id and name attributes not being callable and modify them as it was done for authentic2-auth-fedict. Finally, we could go towards id and name being only callable.