Project

General

Profile

Bug #18771

xmlsec/soap.h replacement

Added by Kranium Gikos Mendoza over 6 years ago. Updated almost 6 years ago.

Status:
Fermé
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
18 September 2017
Due date:
% Done:

100%

Estimated time:
Patch proposed:
Yes
Planning:

Description

xmlsec 1.2.25 has deprecated xmlsec/soap.h and plans to completely remove it in +2 releases.

https://github.com/lsh123/xmlsec/issues/86
https://github.com/lsh123/xmlsec/pull/105

The soap headers are now disabled in xmlsec by default and distros will have to compile with --enable-soap to enable it back.

Raising this ticket to request finding a replacement for xmlsec/soap.h


Files


Related issues

Has duplicate Lasso - Bug #21699: Lasso no longer compiles with xmlsec1 built with default flags.Rejeté08 February 2018

Actions

Associated revisions

Revision 1d56cd1e (diff)
Added by Benjamin Dauvergne about 6 years ago

replace use of <xmlsec/soap.h> which is deprecated (fixes #18771)

History

#1

Updated by Benjamin Dauvergne over 6 years ago

We really don't use it at all:

lasso/id-wsf/wsf_profile.c:     header = xmlSecSoap11GetHeader(envelope);
lasso/id-wsf/wsf_profile.c:     body = xmlSecSoap11GetBody(envelope);
lasso/xml/tools.c:      return xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap11Ns) ||
lasso/xml/tools.c:              xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap12Ns);
lasso/xml/tools.c:      is_soap11 = xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap11Ns);
lasso/xml/tools.c:      is_soap12 = xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap12Ns);
lasso/xml/tools.c:                      body = xmlSecSoap11GetBody(root);
lasso/xml/tools.c:                      body = xmlSecSoap12GetBody(root);

Can you contribute replacement for these line of code ?

I think it would also be the good time to completely remove the incomplete and useless ID-WSF support.

#2

Updated by Kranium Gikos Mendoza over 6 years ago

Apologies for the latency @Benjamin

I am not sure if I have time and expertise in contributing into the c++. I only came across this issue since I package the lasso and mod_auth_mellon in NixOS.

#3

Updated by Benjamin Dauvergne over 6 years ago

Hi, no problem I did it, could you test the following patch and confirm it fixes this problem ?

#4

Updated by Kranium Gikos Mendoza over 6 years ago

I'm afraid the patch appears didn't pick up lasso/xml/xmlsec_soap.h when it was prepared

make[5]: Leaving directory '/tmp/nix-build-lasso-2.5.1.drv-0/lasso-2.5.1/lasso/xml/ecp'
make[5]: Entering directory '/tmp/nix-build-lasso-2.5.1.drv-0/lasso-2.5.1/lasso/xml'
CC tools.lo
tools.c:73:35: fatal error: lasso/xml/xmlsec_soap.h: No such file or directory
#include <lasso/xml/xmlsec_soap.h>
^
compilation terminated.
make[5]: *** [Makefile:1054: tools.lo] Error 1

#6

Updated by Benjamin Dauvergne over 6 years ago

I'll add copyright mentions about xmlsec later (but code is so succint and so evident I don't know if it's mandatory, will do it only because xmlsec is a fine project).

#7

Updated by Thomas Noël over 6 years ago

  • Has duplicate Bug #21699: Lasso no longer compiles with xmlsec1 built with default flags. added
#8

Updated by Benjamin Dauvergne about 6 years ago

  • Status changed from Nouveau to Résolu (à déployer)
  • % Done changed from 0 to 100
#9

Updated by Benjamin Dauvergne almost 6 years ago

  • Assignee set to John Dennis
  • Target version set to 2.6.0
#10

Updated by Benjamin Dauvergne almost 6 years ago

  • Status changed from Résolu (à déployer) to Fermé

Also available in: Atom PDF