Bug #18771
xmlsec/soap.h replacement
100%
Description
xmlsec 1.2.25 has deprecated xmlsec/soap.h and plans to completely remove it in +2 releases.
https://github.com/lsh123/xmlsec/issues/86
https://github.com/lsh123/xmlsec/pull/105
The soap headers are now disabled in xmlsec by default and distros will have to compile with --enable-soap to enable it back.
Raising this ticket to request finding a replacement for xmlsec/soap.h
Files
Related issues
Associated revisions
History
Updated by Benjamin Dauvergne about 6 years ago
We really don't use it at all:
lasso/id-wsf/wsf_profile.c: header = xmlSecSoap11GetHeader(envelope); lasso/id-wsf/wsf_profile.c: body = xmlSecSoap11GetBody(envelope); lasso/xml/tools.c: return xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap11Ns) || lasso/xml/tools.c: xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap12Ns); lasso/xml/tools.c: is_soap11 = xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap11Ns); lasso/xml/tools.c: is_soap12 = xmlSecCheckNodeName(root, xmlSecNodeEnvelope, xmlSecSoap12Ns); lasso/xml/tools.c: body = xmlSecSoap11GetBody(root); lasso/xml/tools.c: body = xmlSecSoap12GetBody(root);
Can you contribute replacement for these line of code ?
I think it would also be the good time to completely remove the incomplete and useless ID-WSF support.
Updated by Kranium Gikos Mendoza almost 6 years ago
Apologies for the latency @Benjamin
I am not sure if I have time and expertise in contributing into the c++. I only came across this issue since I package the lasso and mod_auth_mellon in NixOS.
Updated by Benjamin Dauvergne almost 6 years ago
- File 0001-replace-use-of-xmlsec-soap.h-which-is-deprecated-fix.patch 0001-replace-use-of-xmlsec-soap.h-which-is-deprecated-fix.patch added
- Patch proposed changed from No to Yes
Hi, no problem I did it, could you test the following patch and confirm it fixes this problem ?
Updated by Kranium Gikos Mendoza almost 6 years ago
I'm afraid the patch appears didn't pick up lasso/xml/xmlsec_soap.h
when it was prepared
make[5]: Leaving directory '/tmp/nix-build-lasso-2.5.1.drv-0/lasso-2.5.1/lasso/xml/ecp'
make[5]: Entering directory '/tmp/nix-build-lasso-2.5.1.drv-0/lasso-2.5.1/lasso/xml'
CC tools.lo
tools.c:73:35: fatal error: lasso/xml/xmlsec_soap.h: No such file or directory
#include <lasso/xml/xmlsec_soap.h>
^
compilation terminated.
make[5]: *** [Makefile:1054: tools.lo] Error 1
Updated by Benjamin Dauvergne almost 6 years ago
I'll add copyright mentions about xmlsec later (but code is so succint and so evident I don't know if it's mandatory, will do it only because xmlsec is a fine project).
Updated by Thomas Noël over 5 years ago
- Has duplicate Bug #21699: Lasso no longer compiles with xmlsec1 built with default flags. added
Updated by Benjamin Dauvergne over 5 years ago
- Status changed from Nouveau to Résolu (à déployer)
- % Done changed from 0 to 100
Appliqué par commit 1d56cd1e31ce993ad17f4b4bbc31c12ffff1311f.
Updated by Benjamin Dauvergne about 5 years ago
- Assignee set to John Dennis
- Target version set to 2.6.0
Updated by Benjamin Dauvergne about 5 years ago
- Status changed from Résolu (à déployer) to Fermé
replace use of <xmlsec/soap.h> which is deprecated (fixes #18771)