Projet

Général

Profil

Bug #19486

crash sur cellule newletter lorsque qu'aucun système de newletter n'existe

Ajouté par Thomas Noël il y a plus de 6 ans. Mis à jour il y a plus de 5 ans.

Statut:
Fermé
Priorité:
Normal
Assigné à:
-
Version cible:
-
Début:
17 octobre 2017
Echéance:
% réalisé:

0%

Temps estimé:
Patch proposed:
Oui
Planning:

Description

#19476 ... mais j'ai effacé la trace reçue par mail, si qqun l'a c'est bien

Fichiers

0001-newsletters-protect-render-against-missing-user-1948.patch (932 octets) 0001-newsletters-protect-render-against-missing-user-1948.patch Frédéric Péters, 17 octobre 2017 21:09

Révisions associées

Révision bb2b55cb (diff)
Ajouté par Frédéric Péters il y a plus de 6 ans

newsletters: protect render() against missing user (#19486)

Historique

#2

Mis à jour par Frédéric Péters il y a plus de 6 ans

(Elle est dans sentry.)

#3

Mis à jour par Thomas Noël il y a plus de 6 ans

https://sentry.entrouvert.org/sentry/entrouvert-dev/issues/2340/

AttributeError: 'NoneType' object has no attribute 'is_authenticated'
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/contrib/auth/decorators.py", line 22, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "django/utils/decorators.py", line 110, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/generic/base.py", line 89, in dispatch
    return handler(request, *args, **kwargs)
  File "django/views/generic/detail.py", line 116, in get
    context = self.get_context_data(object=self.object)
  File "combo/manager/views.py", line 213, in get_context_data
    for placeholder in self.object.get_placeholders(traverse_cells=True):
  File "combo/data/models.py", line 209, in get_placeholders
    tmpl.render(context)
  File "django/template/backends/django.py", line 74, in render
    return self.template.render(context)
  File "django/template/base.py", line 210, in render
    return self._render(context)
  File "django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/loader_tags.py", line 135, in render
    return compiled_parent._render(context)
  File "django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/loader_tags.py", line 135, in render
    return compiled_parent._render(context)
  File "django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/loader_tags.py", line 65, in render
    result = block.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/loader_tags.py", line 65, in render
    result = block.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/base.py", line 1294, in render
    return t.render(new_context)
  File "django/template/base.py", line 212, in render
    return self._render(context)
  File "django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/defaulttags.py", line 329, in render
    return nodelist.render(context)
  File "django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "django/template/defaulttags.py", line 217, in render
    nodelist.append(node.render(context))
  File "django/template/base.py", line 1197, in render
    return func(*resolved_args, **resolved_kwargs)
  File "combo/public/templatetags/combo.py", line 88, in render_cell
    return cell.render(context)
  File "combo/apps/newsletters/models.py", line 164, in render
    if user.is_authenticated():
#4

Mis à jour par Frédéric Péters il y a plus de 6 ans

#5

Mis à jour par Thomas Noël il y a plus de 6 ans

Ça n'avait donc rien à voir avec l'existence d'un bidule de newsletter. Ack de toute façon.

#6

Mis à jour par Frédéric Péters il y a plus de 6 ans

  • Statut changé de En cours à Résolu (à déployer)

Un peu à voir quand même.

commit bb2b55cbe38e18bffee69fa3b761db76ddb97592
Author: Frédéric Péters <fpeters@entrouvert.com>
Date:   Tue Oct 17 21:08:36 2017 +0200

    newsletters: protect render() against missing user (#19486)
#7

Mis à jour par Frédéric Péters il y a plus de 5 ans

  • Statut changé de Résolu (à déployer) à Solution déployée

Formats disponibles : Atom PDF