Bug #22717
corrections diverses dans le module OAuth2
Début:
21 mars 2018
Echéance:
% réalisé:
0%
Temps estimé:
Patch proposed:
Oui
Planning:
Description
- messages non localisés
- typo
- logique manquante (suppression systématique du document temporaire)
- changement du modèle OAuth2TempFile qui sert de sas: on ne bloque pas plusieurs PUT du même fichier, et donc on utilise plus le hash du fichier comme clé primaire, on génère un uuid nouveau à chaque fois
- ajout de plein de logs
- ajout d'un lien des autorisations et des documents temporaires vers le modèle du client qui en est responsable
Révisions associées
oauth2: remove unused import (#22717)
oauth2: add localization (#22717)
oauth2: fix typo (#22717)
oauth2: always delete the temp document on a POST (#22717)
oauth2: improve coding style (#22717)
- declare all views with .as_view()
- add helper make_url() to properly add parameters to query string of
redirect_uri - stop threading the redirect_uri through the session
- make POST form target implicit, so that parameters are kept
- do checks in dispatch() to share them between POST and GET methods
oauth2: enforce access_token and code lifetime (#22717)
oauth2: remove useless for check redirect_uri in token endpoint (#22717)
oauth2: update french translations (#22717)
share make_url() with fargo, simplify URL building code (#22717)
oauth2: use client_name as unicode value of clients (#22717)
oauth2: log more (#22717)
oauth2: link authorizations and temp files to clients (#22717)
oauth2: improve logs with new link to clients (#22717)
oauth2: do not use the document hash as primary key for temp files (#22717)
It prevents a client from pushing the same file multiple times, which
makes temporary errors harder to handle (client would have to handle a
failure from the web-service). We allow any number of push of the same
document, orphans will be cleaned up by a background task, and storage
is not duplicated as document are deduplicated through their hash.
fargo: PE8 (#22717)
oauth2: allow modifications of client_id and client_secret (#22717)
Historique
Mis à jour par Benjamin Dauvergne il y a environ 6 ans
- Sujet changé de correction diverses dans les vues OAuth2 à corrections diverses dans les vues OAuth2
- Patch proposed changé de Non à Oui
Mis à jour par Benjamin Dauvergne il y a environ 6 ans
- Sujet changé de corrections diverses dans les vues OAuth2 à corrections diverses dans le module OAuth2
- Description mis à jour (diff)
Mis à jour par Serghei Mihai il y a environ 6 ans
Corriger le message "oauth2: remove useless for check redirect_uri in token endpoint" en "oauth2: remove useless check redirect_uri in token endpoint" et go.
Mis à jour par Benjamin Dauvergne il y a environ 6 ans
- Statut changé de Nouveau à Résolu (à déployer)
commit e98b74dccc74f6f91366a7c6369d305ed3e2e497
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 21:14:24 2018 +0100
oauth2: allow modifications of client_id and client_secret (#22717)
commit c741e8df51e322f72105061d787e6f567c2f2c99
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 21:14:06 2018 +0100
fargo: PE8 (#22717)
commit 59ec2bea1a1afb6b44643af562e442b30059750a
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 11:17:07 2018 +0100
oauth2: do not use the document hash as primary key for temp files (#22717)
It prevents a client from pushing the same file multiple times, which
makes temporary errors harder to handle (client would have to handle a
failure from the web-service). We allow any number of push of the same
document, orphans will be cleaned up by a background task, and storage
is not duplicated as document are deduplicated through their hash.
commit d813e2b16764230c8e90eab5585060a31302e25d
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:51:01 2018 +0100
oauth2: improve logs with new link to clients (#22717)
commit 1dddba4baf421d81a448471de5471b0f5b83a1fe
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:48:00 2018 +0100
oauth2: link authorizations and temp files to clients (#22717)
commit 1803cb9ddf15f0033ef79f38eee11862a91e2a98
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:32:29 2018 +0100
oauth2: log more (#22717)
commit 60d6259023e02b521b899346426e48e2559984b4
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:51:46 2018 +0100
oauth2: use client_name as unicode value of clients (#22717)
commit fc6119683bba5ec2dc589520e242437c2a64e301
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:20:41 2018 +0100
share make_url() with fargo, simplify URL building code (#22717)
commit ab4a137c09e8784f259abe07fb241252fc254a69
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu Mar 22 00:04:06 2018 +0100
oauth2: update french translations (#22717)
commit 49a01aac71921c0ec5ca3e8643ede71c255b6d1b
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 23:50:33 2018 +0100
oauth2: remove useless for check redirect_uri in token endpoint (#22717)
commit fbe0fc0b7872f3233d64d73777c067f364d2057a
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 23:42:17 2018 +0100
oauth2: enforce access_token and code lifetime (#22717)
commit 2fe7382ab39bc2a0d4ccd5b5478bc957c1511674
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 21:44:32 2018 +0100
oauth2: improve coding style (#22717)
* declare all views with .as_view()
* add helper make_url() to properly add parameters to query string of
redirect_uri
* stop threading the redirect_uri through the session
* make POST form target implicit, so that parameters are kept
* do checks in dispatch() to share them between POST and GET methods
commit d5608c7478209b2409663736c364f3ef7761eef0
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 21:02:30 2018 +0100
oauth2: always delete the temp document on a POST (#22717)
commit 114e474d4c434ccd92de77f8ed2f549de28f5bfd
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 21:01:04 2018 +0100
oauth2: fix typo (#22717)
commit 0ec6e92235999976e2b21bf170a730fc8644ada1
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 21:00:15 2018 +0100
oauth2: add localization (#22717)
commit db69542403adc6ceb042de83567aa5fa8de1285b
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 23:50:19 2018 +0100
oauth2: remove unused import (#22717)
commit 3d69062edbcd1114e72953fd67bd68e578e9876c
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Wed Mar 21 23:53:30 2018 +0100
tox.ini: rename coverage file only if coverage is enabled (#22717)
tox.ini: rename coverage file only if coverage is enabled (#22717)