Project

General

Profile

Development #33056

ne pas logguer les erreurs "normales" sur api entreprises

Added by Thomas Noël 9 days ago. Updated 7 days ago.

Status:
Solution déployée
Priority:
Normal
Target version:
-
Start date:
14 May 2019
Due date:
% Done:

0%

Patch proposed:
Yes
Planning:
No

Description

On va (souvent) interroger API Entreprise pour savoir par exemple si un Waldec ou un SIRET/SIREN existe, et donc il ne faut pas logguer les 4xx retournées par cette API

Date: Mon, 13 May 2019 17:41:05 +0200
From: root@passerelle.node2.test.saas.entrouvert.org
To: admin+passerelle.test@entrouvert.com
Subject: [passerelle-arles.test.entrouvert.org] ERROR (EXTERNAL IP): GET https://entreprise.api.gouv.fr/v2/associations/None/ (=> 422)

GET https://entreprise.api.gouv.fr/v2/associations/None/ (=> 422)

Report at /api-entreprise/api-entreprise/associations/None/
GET https://entreprise.api.gouv.fr/v2/associations/None/ (=> 422)

...

0003-api_entreprise-uses-exception_to_text-to-display-exc.patch View (2.1 KB) Benjamin Dauvergne, 14 May 2019 10:48 AM

0005-api_entreprise-prevents-requests-to-log-HTTP-errors-.patch View (866 Bytes) Benjamin Dauvergne, 14 May 2019 10:48 AM

0002-api_entreprise-uses-temporary-to-fix-indentation-330.patch View (1.14 KB) Benjamin Dauvergne, 14 May 2019 10:48 AM

0001-api_entreprise-removes-dead-import-33056.patch View (952 Bytes) Benjamin Dauvergne, 14 May 2019 10:48 AM

0004-api_entreprise-enforces-PEP8-33056.patch View (6.12 KB) Benjamin Dauvergne, 14 May 2019 10:48 AM

Associated revisions

Revision 247149b2 (diff)
Added by Benjamin Dauvergne 8 days ago

api_entreprise: removes dead import (#33056)

Revision b30af7ae (diff)
Added by Benjamin Dauvergne 8 days ago

api_entreprise: uses temporary to fix indentation (#33056)

Revision d18fa62b (diff)
Added by Benjamin Dauvergne 8 days ago

api_entreprise: uses exception_to_text() to display exceptions (#33056)

Revision a2eccafe (diff)
Added by Benjamin Dauvergne 8 days ago

api_entreprise: enforces PEP8 (#33056)

Revision 6d844e15 (diff)
Added by Benjamin Dauvergne 8 days ago

api_entreprise: prevents requests to log HTTP errors (#33056)

History

#1 Updated by Thomas Noël 9 days ago

  • Description updated (diff)

#2 Updated by Benjamin Dauvergne 9 days ago

  • Assignee set to Benjamin Dauvergne

#3 Updated by Benjamin Dauvergne 9 days ago

Seul le dernier patch est vraiment utile au ticket mais bon en passant je nettoye.

#4 Updated by Benjamin Dauvergne 9 days ago

Benjamin Dauvergne a écrit :

Seul le dernier patch est vraiment utile au ticket mais bon en passant je nettoye.

Et merci #31114.

#5 Updated by Serghei Mihai 8 days ago

  • Status changed from Solution proposée to Solution validée

#6 Updated by Benjamin Dauvergne 8 days ago

  • Status changed from Solution validée to Résolu (à déployer)
commit 6d844e152972c151bb58d95b93240b560c2a67ee
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Tue May 14 10:41:43 2019 +0200

    api_entreprise: prevents requests to log HTTP errors (#33056)

commit a2eccafe010ffd589cb75f2208d7da6451bbaa11
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Tue May 14 10:35:21 2019 +0200

    api_entreprise: enforces PEP8 (#33056)

commit d18fa62ba64588965c14e467f350fbd5b4460463
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Tue May 14 10:34:41 2019 +0200

    api_entreprise: uses exception_to_text() to display exceptions (#33056)

commit b30af7aeb7bb47cba5a9c2849e9911d2c42a4056
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Tue May 14 10:34:07 2019 +0200

    api_entreprise: uses temporary to fix indentation (#33056)

commit 247149b2f3764c24064c9da1ab0ef0218c9b49fb
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Tue May 14 10:33:44 2019 +0200

    api_entreprise: removes dead import (#33056)

#7 Updated by Frédéric Péters 7 days ago

  • Status changed from Résolu (à déployer) to Solution déployée

Also available in: Atom PDF