Bug #37450
debug-toolbar mal configurée en python3
Statut:
Rejeté
Priorité:
Normal
Assigné à:
-
Version cible:
-
Début:
05 novembre 2019
Echéance:
% réalisé:
0%
Temps estimé:
Patch proposed:
Non
Planning:
Non
Description
Avec #36894 appliqué (qui contourne le problème en désactivant la debug toolbar), sur un comob-manage migrate_schemas :
Traceback (most recent call last):
File "/home/cazino/src/combo/manage.py", line 10, in <module>
execute_from_command_line(sys.argv)
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
utility.execute()
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/__init__.py", line 356, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
self.execute(*args, **cmd_options)
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/base.py", line 327, in execute
self.check()
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/base.py", line 359, in check
include_deployment_checks=include_deployment_checks,
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/management/base.py", line 346, in _run_checks
return checks.run_checks(**kwargs)
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/django/core/checks/registry.py", line 81, in run_checks
new_errors = check(app_configs=app_configs)
File "/home/cazino/envs/publik-env-py3/lib/python3.7/site-packages/debug_toolbar/apps.py", line 25, in check_middleware
for i, middleware in enumerate(settings.MIDDLEWARE):
TypeError: 'NoneType' object is not iterable
Demandes liées
Historique
Mis à jour par Emmanuel Cazenave il y a plus de 4 ans
- Lié à Development #36894: Débuter la prise en charge de python3 ajouté
Mis à jour par Benjamin Dauvergne il y a plus de 4 ans
Ce patch donnerait un workaround jusqu'à ce que combo utilise MIDDLEWARE :
diff --git roles/app-setup/templates/app-settings-base.j2 roles/app-setup/templates/app-settings-base.j2
index 7c4323a..2dccabd 100644
--- roles/app-setup/templates/app-settings-base.j2
+++ roles/app-setup/templates/app-settings-base.j2
@@ -6,6 +6,8 @@
import glob
import os
+from django.utils import six
+
{% block app_custom_before %}{% endblock %}
PROJECT_NAME = "{{project_name}}"
@@ -45,7 +47,7 @@ LOGGING = {
DEBUG = True
-if PROJECT_NAME in ['authentic', 'combo', 'passerelle']:
+if PROJECT_NAME in ['authentic', 'combo', 'passerelle'] and (vars().get('MIDDLEWARE') or not six.PY3):
try:
import debug_toolbar
except ImportError:
Mis à jour par Emmanuel Cazenave il y a plus de 4 ans
- Statut changé de Nouveau à Rejeté
On va régler ça directement dans #36894 .