Project

General

Profile

Development #40454

lasso does not build reproducibly

Added by Bernhard M. Wiedemann 3 months ago. Updated 3 months ago.

Status:
Fermé
Priority:
Normal
Assignee:
-
Category:
Binding python
Target version:
-
Start date:
05 Mar 2020
Due date:
% Done:

50%

Patch proposed:
Yes
Planning:
No

Description

While working on reproducible builds for openSUSE, I found that
our lasso package varied from nondeterministic filesystem readdir order
in lasso/types.c , lasso.py and liblasso.so.3.13.0

See https://reproducible-builds.org/ for why this matters.

Please review/test/merge the attached patch.

0001-Sort-input-file-lists.patch View (1.83 KB) Bernhard M. Wiedemann, 05 Mar 2020 12:13 PM

Associated revisions

Revision 1b51873c (diff)
Added by Bernhard M. Wiedemann 3 months ago

Sort input file lists (#40454)

so that lasso.py, lasso/types.c and liblasso.so.3.13.0
build reproducibly
in spite of indeterministic filesystem readdir order.
For some reason, lasso/extract_sections.py lasso/extract_symbols.py
do not need such patches to get a reproducible openSUSE package.

See https://reproducible-builds.org/ for why this is good.

This patch was done while working on reproducible builds for openSUSE.

License: MIT
Signed-off-by: Bernhard M. Wiedemann <>

History

#1 Updated by Benjamin Dauvergne 3 months ago

  • Status changed from Nouveau to Solution validée

Great, thanks.

#2 Updated by Benjamin Dauvergne 3 months ago

  • Status changed from Solution validée to Fermé
commit 1b51873ccfccf9dde981ef4aecba7656bad4056b
Author: Bernhard M. Wiedemann <bwiedemann@suse.de>
Date:   Tue Mar 3 11:31:56 2020 +0100

    Sort input file lists (#40454)

    so that lasso.py, lasso/types.c and liblasso.so.3.13.0
    build reproducibly
    in spite of indeterministic filesystem readdir order.
    For some reason, lasso/extract_sections.py lasso/extract_symbols.py
    do not need such patches to get a reproducible openSUSE package.

    See https://reproducible-builds.org/ for why this is good.

    This patch was done while working on reproducible builds for openSUSE.

    License: MIT
    Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>

Also available in: Atom PDF