Development #4097
argument popping handled differently with different backends
0%
Description
Hello again.
When working with eopayment with the systempay backend, I had some trouble with the fact that the relevant Payment objects pops some arguments from is option dictionary on instanciation. I could work around that, but now i'm noticing that the SIPS backend does some poping too, but in its execute method rather than on instanciation, which is making handling both backends in a similar way difficult.
I'm not sure why this is handled differently, but here's a patch that makes the SIPS backend behaves more like the sytempay one (i chose to go this way mostly out of convenience, both for me and because it requires less changes). I have tested only locally, so while it works when sending a request, i can't assert it does when receiving the bank's response yet. Since the parameter is used in a single method (execute, called by both request and response), i'm assuming this won't cause trouble.
Fichiers
Historique
Mis à jour par Benjamin Dauvergne il y a plus de 10 ans
It's ok, pushed. As I said before only the systempay and spplus are used and tested by our society, it explains why some things seem more rational in them.
Mis à jour par Benjamin Dauvergne il y a environ 8 ans
- Version cible mis à 1.2
- Patch proposed mis à Non