Project

General

Profile

Development #41262

signature.py : ne pas obliger les nonces si y'a pas de vérificateur, et autres corrections

Added by Thomas Noël 2 months ago. Updated 2 months ago.

Status:
Résolu (à déployer)
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
02 Apr 2020
Due date:
% Done:

0%

Patch proposed:
Yes
Planning:
No

Description

Ca vient surtout de choses vues lors de #41245

0001-signature-do-not-require-nonce-if-not-verified-and-o.patch View (5.83 KB) Thomas Noël, 02 Apr 2020 02:26 PM

History

#1 Updated by Thomas Noël 2 months ago

On note au passage qu'un test était juste faux, il aurait dû planter :

   assert signature.check_url(signature.sign_url(URL, KEY, nonce='xxx'), KEY,
           known_nonce=lambda nonce: nonce == 'xxx')

c'est corrigé ici.

#2 Updated by Benjamin Dauvergne 2 months ago

Ça build pas.

#3 Updated by Thomas Noël 2 months ago

En fait ça ne builde pas sur un problème Authentic (#41284 ?)

ERROR:   py2-authentic: commands failed
  py2-hobo: commands succeeded
  py2-multipublik: commands succeeded
  py2-multitenant: commands succeeded
  py2-multitenant-oldstylemiddleware: commands succeeded
  py2-passerelle: commands succeeded
  py2-schemas: commands succeeded
ERROR:   py3-coverage-authentic: commands failed
  py3-coverage-hobo: commands succeeded
  py3-coverage-multipublik: commands succeeded
  py3-coverage-multitenant: commands succeeded
  py3-coverage-multitenant-oldstylemiddleware: commands succeeded
  py3-coverage-passerelle: commands succeeded
  py3-coverage-schemas: commands succeeded

#4 Updated by Benjamin Dauvergne 2 months ago

  • Status changed from Solution proposée to Solution validée

Ouaip, je valide donc.

#5 Updated by Thomas Noël 2 months ago

  • Status changed from Solution validée to Résolu (à déployer)

Merci.

commit df903c40b3dd3fe1ccd9eefa302e0fc8613eb4a1
Author: Thomas NOEL <tnoel@entrouvert.com>
Date:   Thu Apr 2 13:50:36 2020 +0200

    signature: do not require nonce if not verified, and other fixes (#)

#6 Updated by Thomas Noël 2 months ago

(et zut, numéro de ticket oublié dans le commit... tant pis)

Also available in: Atom PDF