Project

General

Profile

Développement #42073

remplacer les usages de g_type_class_add_private par G_DEFINE_TYPE_WITH_PRIVATE

Added by Benjamin Dauvergne (retour le 1er août) about 5 years ago. Updated 6 months ago.

Status:
Résolu (à déployer)
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
24 April 2020
Due date:
% Done:

0%

Estimated time:
Patch proposed:
No
Planning:
No

Description

Ça va finir par disparaître des versions de glib dans debian stable et on ne sera pas prêt.

Il faut renommer au passage les class_init/instance_init en prefix#_class_init et prefix#_init.

À noter la particularité de LassoLogin (lasso/id-ff/login.c) qui doit donner des accès à ses variables privées à lasso/saml-2.0/login.c à l'occassion il faudrait déprécier l'accès donner via LassoLogin.private_data et voir pour partager des accesseurs non publiés à la place et déprécier LassoLogin.private_data (le renommer en deprecated pour ne pas changer la taille de la structure).


Related issues

Related to Lasso - Développement #56668: Fix warning about deprecation of g_type_class_add_privateFermé06 September 2021

Actions

Associated revisions

Revision 0d2224fb (diff)
Added by Yann Weber 6 months ago

misc: replace deprecated g_type_class_add_private (#42073)

Revision 86ea84df (diff)
Added by Yann Weber 6 months ago

login: depreciate LassoLogin.private_data (#42073)

Adds non-exported accessors used in lasso/saml-2.0/login.c

Revision 155abbdf (diff)
Added by Yann Weber 6 months ago

profile: depreciate LassoProfile.private_data (#42073)

Revision 824591b7 (diff)
Added by Yann Weber 6 months ago

key: depreciate LassoKey.private_data (#42073)

Revision d6b7ff8e (diff)
Added by Yann Weber 6 months ago

session: depreciate LassoSession.private_data (#42073)

Revision 75a365fd (diff)
Added by Yann Weber 6 months ago

provider: depreciate LassoProvider.private_data (#42073)

Revision 7391ce15 (diff)
Added by Yann Weber 6 months ago

ds_x509_data: depreciate LassoDsX509Data.private_data (#42073)

History

#1

Updated by Benjamin Dauvergne (retour le 1er août) about 5 years ago

  • Description updated (diff)
#2

Updated by Benjamin Dauvergne (retour le 1er août) about 5 years ago

  • Description updated (diff)
  • Target version set to 2.6.2
#3

Updated by Benjamin Dauvergne (retour le 1er août) 8 months ago

#4

Updated by Robot Gitea 7 months ago

  • Status changed from Nouveau to En cours
  • Assignee set to Yann Weber

Yann Weber (yweber) a ouvert une pull request sur Gitea concernant cette demande :

#5

Updated by Robot Gitea 7 months ago

  • Status changed from En cours to Solution proposée
#6

Updated by Robot Gitea 7 months ago

  • Status changed from Solution proposée to En cours

Benjamin Dauvergne (bdauvergne) a relu et demandé des modifications sur une pull request sur Gitea concernant cette demande :

#7

Updated by Robot Gitea 7 months ago

  • Status changed from En cours to Solution proposée
#8

Updated by Robot Gitea 7 months ago

  • Status changed from Solution proposée to Solution validée

Benjamin Dauvergne (bdauvergne) a approuvé une pull request sur Gitea concernant cette demande :

#9

Updated by Xavier Bachelot 6 months ago

PR24 breaks build on EL8:
saml2_subject_confirmation_data.c: In function 'lasso_saml2_subject_confirmation_data_init':
saml2_subject_confirmation_data.c:105:44: error: parameter name omitted
lasso_saml2_subject_confirmation_data_init(LassoSaml2SubjectConfirmationData G_GNUC_UNUSED)
make5: *
* [Makefile:765: saml2_subject_confirmation_data.lo] Error 1

It does build fine on Fedora and EL9/10 though.

#10

Updated by Yann Weber 6 months ago

Xavier Bachelot a écrit :

saml2_subject_confirmation_data.c:105:44: error: parameter name omitted
lasso_saml2_subject_confirmation_data_init(LassoSaml2SubjectConfirmationData G_GNUC_UNUSED)
make5: *
* [Makefile:765: saml2_subject_confirmation_data.lo] Error 1

The PR was updated thanks to your message.

#11

Updated by Robot Gitea 6 months ago

  • Status changed from Solution validée to Résolu (à déployer)

Benjamin Dauvergne (bdauvergne) a mergé une pull request sur Gitea concernant cette demande :

#12

Updated by Xavier Bachelot 6 months ago

There's a new one now :
misc_text_node.c: In function 'lasso_misc_text_node_init':
misc_text_node.c:144:27: error: parameter name omitted
lasso_misc_text_node_init(LassoMiscTextNode G_GNUC_UNUSED)
make5: *
* [Makefile:796: misc_text_node.lo] Error 1

Also available in: Atom PDF