Projet

Général

Profil

Development #56883

ID-WSF removal removed too many symbols

Ajouté par Frédéric Péters il y a plus de 2 ans. Mis à jour il y a plus de 2 ans.

Statut:
Fermé
Priorité:
Normal
Assigné à:
Benjamin Dauvergne
Catégorie:
-
Version cible:
-
Début:
12 septembre 2021
Echéance:
% réalisé:

0%

Temps estimé:
Patch proposed:
Oui
Planning:
Non

Description

lasso_register_dst_service (at least) was built and exported even without --enable-id-wsf. It shouldn't have been removed. (or the soname should be bumped)

Fichiers

0001-restore-some-ID-WSF-functions-to-keep-current-ABI-as.patch (3,89 ko) 0001-restore-some-ID-WSF-functions-to-keep-current-ABI-as.patch Benjamin Dauvergne, 13 septembre 2021 11:21
0001-Keep-ABI-stability-56883.patch (4,21 ko) 0001-Keep-ABI-stability-56883.patch Benjamin Dauvergne, 13 septembre 2021 12:15

Révisions associées

Révision d80357e2 (diff)
Ajouté par Benjamin Dauvergne il y a plus de 2 ans

Keep ABI stability (#56883)

The following functions where part of the experimental ID-WSF support
recently removed but where incorrectly included in the official ABI, so we
restore dummy versions of them (they do nothing or return NULL):
- lasso_get_prefix_for_dst_service_href
- lasso_get_prefix_for_idwsf2_dst_service_href
- lasso_register_dst_service
- lasso_register_idwsf2_dst_service

Historique

#2

Mis à jour par Benjamin Dauvergne il y a plus de 2 ans

If I restore dummy functions with same name, would it be enough ? They have no use without the rest of the ID-WSF code.

#3

Mis à jour par Frédéric Péters il y a plus de 2 ans

Same name and signature iirc, for:

LASSO_EXPORT void lasso_register_dst_service(const char *prefix, const char *href);
LASSO_EXPORT char* lasso_get_prefix_for_dst_service_href(const char *href);
LASSO_EXPORT void lasso_register_idwsf2_dst_service(const gchar *prefix, const gchar *href);
LASSO_EXPORT gchar* lasso_get_prefix_for_idwsf2_dst_service_href(const gchar *href);
#4

Mis à jour par Benjamin Dauvergne il y a plus de 2 ans

  • Assigné à mis à Benjamin Dauvergne
#5

Mis à jour par Benjamin Dauvergne il y a plus de 2 ans

#7

Mis à jour par Benjamin Dauvergne il y a plus de 2 ans

  • Statut changé de Solution proposée à Résolu (à déployer)
commit d80357e22635888764c9a07eb2604a6d0cb56f91
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Mon Sep 13 11:20:52 2021 +0200

    Keep ABI stability (#56883)

    The following functions where part of the experimental ID-WSF support
    recently removed but where incorrectly included in the official ABI, so we
    restore dummy versions of them (they do nothing or return NULL):
    - lasso_get_prefix_for_dst_service_href
    - lasso_get_prefix_for_idwsf2_dst_service_href
    - lasso_register_dst_service
    - lasso_register_idwsf2_dst_service
#8

Mis à jour par Transition automatique il y a plus d'un an

Automatic expiration

Formats disponibles : Atom PDF