Project

General

Profile

Development #56883

ID-WSF removal removed too many symbols

Added by Frédéric Péters 16 days ago. Updated 15 days ago.

Status:
Résolu (à déployer)
Priority:
Normal
Category:
-
Target version:
-
Start date:
12 Sep 2021
Due date:
% Done:

0%

Estimated time:
Patch proposed:
Yes
Planning:
No

Description

lasso_register_dst_service (at least) was built and exported even without --enable-id-wsf. It shouldn't have been removed. (or the soname should be bumped)


Files

Associated revisions

Revision d80357e2 (diff)
Added by Benjamin Dauvergne 15 days ago

Keep ABI stability (#56883)

The following functions where part of the experimental ID-WSF support
recently removed but where incorrectly included in the official ABI, so we
restore dummy versions of them (they do nothing or return NULL):
- lasso_get_prefix_for_dst_service_href
- lasso_get_prefix_for_idwsf2_dst_service_href
- lasso_register_dst_service
- lasso_register_idwsf2_dst_service

History

#2

Updated by Benjamin Dauvergne 16 days ago

If I restore dummy functions with same name, would it be enough ? They have no use without the rest of the ID-WSF code.

#3

Updated by Frédéric Péters 16 days ago

Same name and signature iirc, for:

LASSO_EXPORT void lasso_register_dst_service(const char *prefix, const char *href);
LASSO_EXPORT char* lasso_get_prefix_for_dst_service_href(const char *href);
LASSO_EXPORT void lasso_register_idwsf2_dst_service(const gchar *prefix, const gchar *href);
LASSO_EXPORT gchar* lasso_get_prefix_for_idwsf2_dst_service_href(const gchar *href);
#4

Updated by Benjamin Dauvergne 15 days ago

  • Assignee set to Benjamin Dauvergne
#5

Updated by Benjamin Dauvergne 15 days ago

#7

Updated by Benjamin Dauvergne 15 days ago

  • Status changed from Solution proposée to Résolu (à déployer)
commit d80357e22635888764c9a07eb2604a6d0cb56f91
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Mon Sep 13 11:20:52 2021 +0200

    Keep ABI stability (#56883)

    The following functions where part of the experimental ID-WSF support
    recently removed but where incorrectly included in the official ABI, so we
    restore dummy versions of them (they do nothing or return NULL):
    - lasso_get_prefix_for_dst_service_href
    - lasso_get_prefix_for_idwsf2_dst_service_href
    - lasso_register_dst_service
    - lasso_register_idwsf2_dst_service

Also available in: Atom PDF