https://dev.entrouvert.org/
https://dev.entrouvert.org/favicon.ico?1586192034
2021-09-21T15:09:38Z
Redmine Entr’ouvert
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=327920
2021-09-21T15:09:38Z
Valentin Deniaud
<ul><li><strong>Fichier</strong> <a href="/attachments/57753">0035-misc-fix-use-dict-literal-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57753/0035-misc-fix-use-dict-literal-pylint-error-56982.patch">0035-misc-fix-use-dict-literal-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57754">0023-misc-fix-no-value-for-parameter-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57754/0023-misc-fix-no-value-for-parameter-pylint-error-56982.patch">0023-misc-fix-no-value-for-parameter-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57755">0056-misc-fix-logging-fstring-interpolation-pylint-error-.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57755/0056-misc-fix-logging-fstring-interpolation-pylint-error-.patch">0056-misc-fix-logging-fstring-interpolation-pylint-error-.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57756">0054-misc-fix-raising-format-tuple-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57756/0054-misc-fix-raising-format-tuple-pylint-error-56982.patch">0054-misc-fix-raising-format-tuple-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57757">0036-misc-fix-dangerous-default-value-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57757/0036-misc-fix-dangerous-default-value-pylint-error-56982.patch">0036-misc-fix-dangerous-default-value-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57758">0004-misc-fix-empty-docstrings-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57758/0004-misc-fix-empty-docstrings-pylint-error-56982.patch">0004-misc-fix-empty-docstrings-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57759">0022-misc-fix-assignment-from-no-return-pylint-error-5698.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57759/0022-misc-fix-assignment-from-no-return-pylint-error-5698.patch">0022-misc-fix-assignment-from-no-return-pylint-error-5698.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57760">0037-misc-fix-pointless-statement-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57760/0037-misc-fix-pointless-statement-pylint-error-56982.patch">0037-misc-fix-pointless-statement-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57761">0019-misc-fix-import-error-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57761/0019-misc-fix-import-error-pylint-error-56982.patch">0019-misc-fix-import-error-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57762">0053-misc-fix-try-except-raise-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57762/0053-misc-fix-try-except-raise-pylint-error-56982.patch">0053-misc-fix-try-except-raise-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57763">0049-misc-fix-unused-import-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57763/0049-misc-fix-unused-import-pylint-error-56982.patch">0049-misc-fix-unused-import-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57764">0039-misc-fix-unnecessary-pass-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57764/0039-misc-fix-unnecessary-pass-pylint-error-56982.patch">0039-misc-fix-unnecessary-pass-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57765">0047-misc-fix-global-variable-not-assigned-pylint-error-5.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57765/0047-misc-fix-global-variable-not-assigned-pylint-error-5.patch">0047-misc-fix-global-variable-not-assigned-pylint-error-5.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57766">0006-misc-fix-misplaced-comparison-constant-pylint-error-.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57766/0006-misc-fix-misplaced-comparison-constant-pylint-error-.patch">0006-misc-fix-misplaced-comparison-constant-pylint-error-.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57767">0031-misc-fix-no-else-break-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57767/0031-misc-fix-no-else-break-pylint-error-56982.patch">0031-misc-fix-no-else-break-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57768">0055-misc-fix-logging-not-lazy-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57768/0055-misc-fix-logging-not-lazy-pylint-error-56982.patch">0055-misc-fix-logging-not-lazy-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57769">0032-misc-fix-consider-using-in-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57769/0032-misc-fix-consider-using-in-pylint-error-56982.patch">0032-misc-fix-consider-using-in-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57770">0057-misc-fix-f-string-without-interpolation-pylint-error.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57770/0057-misc-fix-f-string-without-interpolation-pylint-error.patch">0057-misc-fix-f-string-without-interpolation-pylint-error.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57771">0003-decorators-remove-broken-and-unused-decorator-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57771/0003-decorators-remove-broken-and-unused-decorator-56982.patch">0003-decorators-remove-broken-and-unused-decorator-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57772">0028-misc-fix-useless-return-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57772/0028-misc-fix-useless-return-pylint-error-56982.patch">0028-misc-fix-useless-return-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57773">0034-misc-fix-consider-using-with-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57773/0034-misc-fix-consider-using-with-pylint-error-56982.patch">0034-misc-fix-consider-using-with-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57774">0043-misc-fix-useless-super-delegation-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57774/0043-misc-fix-useless-super-delegation-pylint-error-56982.patch">0043-misc-fix-useless-super-delegation-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57775">0052-misc-fix-unbalanced-tuple-unpacking-pylint-error-569.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57775/0052-misc-fix-unbalanced-tuple-unpacking-pylint-error-569.patch">0052-misc-fix-unbalanced-tuple-unpacking-pylint-error-569.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57776">0020-misc-fix-used-before-assignment-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57776/0020-misc-fix-used-before-assignment-pylint-error-56982.patch">0020-misc-fix-used-before-assignment-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57777">0016-misc-fix-access-member-before-definition-pylint-erro.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57777/0016-misc-fix-access-member-before-definition-pylint-erro.patch">0016-misc-fix-access-member-before-definition-pylint-erro.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57778">0021-misc-fixundefined-variable-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57778/0021-misc-fixundefined-variable-pylint-error-56982.patch">0021-misc-fixundefined-variable-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57779">0029-misc-fix-consider-using-in-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57779/0029-misc-fix-consider-using-in-pylint-error-56982.patch">0029-misc-fix-consider-using-in-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57780">0058-misc-fix-redundant-unittest-assert-pylint-error-5698.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57780/0058-misc-fix-redundant-unittest-assert-pylint-error-5698.patch">0058-misc-fix-redundant-unittest-assert-pylint-error-5698.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57781">0026-misc-fix-simplifiable-if-statement-pylint-error-5698.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57781/0026-misc-fix-simplifiable-if-statement-pylint-error-5698.patch">0026-misc-fix-simplifiable-if-statement-pylint-error-5698.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57782">0009-misc-fix-consider-using-dict-items-pylint-error-5698.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57782/0009-misc-fix-consider-using-dict-items-pylint-error-5698.patch">0009-misc-fix-consider-using-dict-items-pylint-error-5698.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57783">0017-misc-fix-no-self-argument-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57783/0017-misc-fix-no-self-argument-pylint-error-56982.patch">0017-misc-fix-no-self-argument-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57784">0042-misc-fix-comparison-with-callable-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57784/0042-misc-fix-comparison-with-callable-pylint-error-56982.patch">0042-misc-fix-comparison-with-callable-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57785">0027-misc-fix-consider-using-ternary-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57785/0027-misc-fix-consider-using-ternary-pylint-error-56982.patch">0027-misc-fix-consider-using-ternary-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57786">0048-misc-fix-global-statement-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57786/0048-misc-fix-global-statement-pylint-error-56982.patch">0048-misc-fix-global-statement-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57787">0041-misc-fix-eval-used-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57787/0041-misc-fix-eval-used-pylint-error-56982.patch">0041-misc-fix-eval-used-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57788">0014-misc-fix-return-in-init-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57788/0014-misc-fix-return-in-init-pylint-error-56982.patch">0014-misc-fix-return-in-init-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57789">0051-misc-fix-unused-wildcard-import-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57789/0051-misc-fix-unused-wildcard-import-pylint-error-56982.patch">0051-misc-fix-unused-wildcard-import-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57790">0033-misc-fix-no-else-continue-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57790/0033-misc-fix-no-else-continue-pylint-error-56982.patch">0033-misc-fix-no-else-continue-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57791">0050-misc-fix-unused-variable-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57791/0050-misc-fix-unused-variable-pylint-error-56982.patch">0050-misc-fix-unused-variable-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57792">0010-misc-fix-line-too-long-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57792/0010-misc-fix-line-too-long-pylint-error-56982.patch">0010-misc-fix-line-too-long-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57793">0015-misc-fix-function-redefined-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57793/0015-misc-fix-function-redefined-pylint-error-56982.patch">0015-misc-fix-function-redefined-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57794">0024-misc-fix-logging-too-many-args-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57794/0024-misc-fix-logging-too-many-args-pylint-error-56982.patch">0024-misc-fix-logging-too-many-args-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57795">0046-misc-fix-reimported-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57795/0046-misc-fix-reimported-pylint-error-56982.patch">0046-misc-fix-reimported-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57796">0002-tests-replace-norequest-decorator-by-explicit-functi.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57796/0002-tests-replace-norequest-decorator-by-explicit-functi.patch">0002-tests-replace-norequest-decorator-by-explicit-functi.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57797">0001-misc-update-pylint-configuration-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57797/0001-misc-update-pylint-configuration-56982.patch">0001-misc-update-pylint-configuration-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57798">0013-misc-fix-len-as-condition-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57798/0013-misc-fix-len-as-condition-pylint-error-56982.patch">0013-misc-fix-len-as-condition-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57799">0005-misc-fix-singleton-comparison-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57799/0005-misc-fix-singleton-comparison-pylint-error-56982.patch">0005-misc-fix-singleton-comparison-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57800">0012-misc-fix-ungrouped-imports-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57800/0012-misc-fix-ungrouped-imports-pylint-error-56982.patch">0012-misc-fix-ungrouped-imports-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57801">0045-misc-fix-wildcard-import-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57801/0045-misc-fix-wildcard-import-pylint-error-56982.patch">0045-misc-fix-wildcard-import-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57802">0007-misc-fix-unidiomatic-typecheck-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57802/0007-misc-fix-unidiomatic-typecheck-pylint-error-56982.patch">0007-misc-fix-unidiomatic-typecheck-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57803">0044-misc-fix-arguments-renamed-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57803/0044-misc-fix-arguments-renamed-pylint-error-56982.patch">0044-misc-fix-arguments-renamed-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57804">0025-misc-fix-consider-using-from-import-pylint-error-569.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57804/0025-misc-fix-consider-using-from-import-pylint-error-569.patch">0025-misc-fix-consider-using-from-import-pylint-error-569.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57805">0018-misc-fix-invalid-str-returned-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57805/0018-misc-fix-invalid-str-returned-pylint-error-56982.patch">0018-misc-fix-invalid-str-returned-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57806">0011-misc-fix-wrong-import-order-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57806/0011-misc-fix-wrong-import-order-pylint-error-56982.patch">0011-misc-fix-wrong-import-order-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57807">0030-misc-fix-no-else-raise-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57807/0030-misc-fix-no-else-raise-pylint-error-56982.patch">0030-misc-fix-no-else-raise-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57808">0040-misc-fix-unnecessary-lambda-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57808/0040-misc-fix-unnecessary-lambda-pylint-error-56982.patch">0040-misc-fix-unnecessary-lambda-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57809">0059-misc-fix-deprecated-method-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57809/0059-misc-fix-deprecated-method-pylint-error-56982.patch">0059-misc-fix-deprecated-method-pylint-error-56982.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57810">0038-misc-fix-pointless-string-statement-pylint-error-569.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57810/0038-misc-fix-pointless-string-statement-pylint-error-569.patch">0038-misc-fix-pointless-string-statement-pylint-error-569.patch</a> ajouté</li><li><strong>Fichier</strong> <a href="/attachments/57811">0008-misc-fix-bad-classmethod-argument-pylint-error-56982.patch</a> <a class="icon-only icon-download" title="Télécharger" href="/attachments/download/57811/0008-misc-fix-bad-classmethod-argument-pylint-error-56982.patch">0008-misc-fix-bad-classmethod-argument-pylint-error-56982.patch</a> ajouté</li><li><strong>Statut</strong> changé de <i>Nouveau</i> à <i>Solution proposée</i></li><li><strong>Patch proposed</strong> changé de <i>Non</i> à <i>Oui</i></li></ul><p>Voilà, je veux bien que ce soit regardé rapidement pour que je puisse pousser ça en tout début de cycle, les rebases s'annonçant relous.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=327927
2021-09-21T15:21:10Z
Frédéric Péters
fpeters@entrouvert.com
<ul></ul><p>Dans misc: fix pointless-statement pylint error,</p>
<pre>
self.ldap(command, attrs)
- state == COMMAND
attrs = {}
</pre>
<p>ça devrait être <code>state = COMMAND</code>.</p>
<p><code>misc: fixundefined-variable pylint error</code> un espace manquant dans le sujet de ce commit.</p>
<p>(voilà pour une lecture un peu au-delà du survol).</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=327931
2021-09-21T15:28:12Z
Valentin Deniaud
<ul></ul><p>Merci, branche à jour.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=327990
2021-09-21T23:27:13Z
Benjamin Dauvergne
<ul></ul><p>Valentin Deniaud a écrit :</p>
<blockquote>
<p>Merci, branche à jour.</p>
</blockquote>
<p>Je préfère que pylint reste une cible à part de tox, mais la commande peut être simplifié bien sûr (<del>pylint.sh me semble toujours inutile</del> je comprends que c'est pour ne pas pourrir les logs dans jenkins, ok).</p>
<hr />
<ul>
<li>misc: fix assignment-from-no-return pylint error (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Development: Faire planter le build sur les erreurs pylint (Fermé)" href="https://dev.entrouvert.org/issues/56982">#56982</a>)</li>
</ul>
<pre>
diff --git a/src/authentic2/manager/user_views.py b/src/authentic2/manager/user_views.py
index 57ea081..1fa7d56 100644
--- a/src/authentic2/manager/user_views.py
+++ b/src/authentic2/manager/user_views.py
@@ -666,8 +666,8 @@ class UserRolesView(HideOUColumnMixin, BaseSubTableView):
qs = list(qs)
return qs
- def authorize(self, request, *args, **kwargs):
- response = super().authorize(request, *args, **kwargs)
+ def dispatch(self, request, *args, **kwargs):
+ response = super().dispatch(request, *args, **kwargs) # pylint: disable=assignment-from-no-return
if response is not None:
return response
if not UserDetailView.has_perm_on_roles(request.user, self.object):
diff --git a/src/authentic2/manager/views.py b/src/authentic2/manager/views.py
index 9446d8e..8a6c5c5 100644
--- a/src/authentic2/manager/views.py
+++ b/src/authentic2/manager/views.py
@@ -119,7 +119,7 @@ class PermissionMixin:
raise PermissionDenied
def dispatch(self, request, *args, **kwargs):
- response = self.authorize(request, *args, **kwargs)
+ response = self.authorize(request, *args, **kwargs) # pylint: disable=assignment-from-no-return
if response is not None:
return response
return super().dispatch(request, *args, **kwargs)
</pre>
<p>Je pense qu'il faut juste ajouter <code>return None</code> dans la méthode authorize de base, pour que pylint comprenne qu'un retour est possible (ça vient de e4e1bccdf335)</p>
<hr />
<ul>
<li>misc: fix no-value-for-parameter pylint error (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Development: Faire planter le build sur les erreurs pylint (Fermé)" href="https://dev.entrouvert.org/issues/56982">#56982</a>)</li>
</ul>
<p>auth2-ssl est du code mort ça peut être juste viré.</p>
<hr />
<ul>
<li>misc: fix comparison-with-callable pylint error (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Development: Faire planter le build sur les erreurs pylint (Fermé)" href="https://dev.entrouvert.org/issues/56982">#56982</a>)</li>
</ul>
<pre>
kind = attribute.get_kind()
+ # pylint: disable=comparison-with-callable
if kind['serialize'] == attribute_kinds.identity:
</pre>
<p>Là je pense que ça appelle juste un remplacement par <code>is</code>.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328105
2021-09-22T12:29:21Z
Valentin Deniaud
<ul></ul><p>Benjamin Dauvergne a écrit :</p>
<blockquote>
<p>Je préfère que pylint reste une cible à part de tox</p>
</blockquote>
<p>Le problème c'est que pylint a besoin de toutes les dépendances d'authentic pour fonctionner, afin de checker les imports. Donc il faut qu'il soit dans la même cible, si il y a une manière d'hériter les dépendances d'une cible à l'autre je ne la connais pas ; ça m'amènerait de toute façon à dire que je préfère avoir la même conf que dans les autres briques plutôt qu'un truc bizarre spécifique a2.</p>
<blockquote>
<p>Je pense qu'il faut juste ajouter return None</p>
</blockquote>
<p>Non sinon tu te prends une erreur useless-return. De toute façon je trouve le code concerné vraiment pas clair, ça demanderait un bon refactoring et les disable pylint font un bon job à le souligner.</p>
<blockquote>
<p>auth2-ssl est du code mort ça peut être juste viré.</p>
</blockquote>
<p>Mmmh, pas de code mais les migrations sont encore là, j'ai peur de l'anguille sous le caillou. Il y a déjà suffisamment d'occasion que quelque chose pète avec les changements introduits ici, laissons ça pour un autre ticket.</p>
<blockquote>
<p>Là je pense que ça appelle juste un remplacement par is.</p>
</blockquote>
<p>Bien vu, branche à jour.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328108
2021-09-22T12:53:24Z
Benjamin Dauvergne
<ul></ul><p>Le mer. 22 sept. 2021 à 14:29, <<a class="email" href="mailto:redmine@entrouvert.com">redmine@entrouvert.com</a>> a écrit :</p>
<blockquote>
<p>Benjamin Dauvergne a écrit :</p>
<blockquote>
<p>Je préfère que pylint reste une cible à part de tox</p>
</blockquote>
<p>Le problème c'est que pylint a besoin de toutes les dépendances d'authentic pour fonctionner, afin de checker les imports. Donc il faut qu'il soit dans la même cible, si il y a une manière d'hériter les dépendances d'une cible à l'autre je ne la connais pas ; ça m'amènerait de toute façon à dire que je préfère avoir la même conf que dans les autres briques plutôt qu'un truc bizarre spécifique a2.</p>
</blockquote>
Les dépendances d'a2 sont dans le setup.py, quelles dépendances vois-tu qui n'y seraient pas ? Pour les dépendances explicites des tests, ça représente très peu de choses qu'on peut rajouter :
<ul>
<li>django_webtest</li>
<li>faker</li>
<li>httmock</li>
<li>lxml</li>
<li>ldaptools</li>
<li>pyquery</li>
</ul>
<p>Mais plutôt que de faire la liste ça peut très bien aller dans un fichier test_requirements.txt, ça s'utilise avec <code>-r</code> dans tox; je vais ouvrir un ticket pour ça.</p>
<blockquote><blockquote>
<p>Je pense qu'il faut juste ajouter return None</p>
</blockquote>
<p>Non sinon tu te prends une erreur useless-return. De toute façon je trouve le code concerné vraiment pas clair, ça demanderait un bon refactoring et les disable pylint font un bon job à le souligner.</p>
</blockquote>
<p>Je ne comprends pas bien ce qu'il y a d'exotique en général et en particulier pour pylint, c'est un code classique avec Django qui répond un HttpResponse pour intercepter le traitement ou None pour laisser la suite continuer; les middleware process_request ou process_view fonctionnent ainsi aussi, mais c'est peut-être pylint dont l'analyse est un peu naze.</p>
<blockquote><blockquote>
<p>auth2-ssl est du code mort ça peut être juste viré.</p>
</blockquote>
<p>Mmmh, pas de code mais les migrations sont encore là, j'ai peur de l'anguille sous le caillou. Il y a déjà suffisamment d'occasion que quelque chose pète avec les changements introduits ici, laissons ça pour un autre ticket.</p>
</blockquote>
<p>L'application n'est plus déclaré dans INSTALLED_APPS, il n'y a aucun risque, mais ok pour un autre ticket.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328117
2021-09-22T13:19:26Z
Valentin Deniaud
<ul></ul><p>Benjamin Dauvergne a écrit :</p>
<blockquote>
<p>Je préfère que pylint reste une cible à part de tox</p>
</blockquote>
<p>OK, branche à jour avec ça.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328296
2021-09-23T13:36:24Z
Benjamin Dauvergne
<ul><li><strong>Statut</strong> changé de <i>Solution proposée</i> à <i>Solution validée</i></li></ul><p>Go, à pousser demain.</p>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328428
2021-09-24T09:44:30Z
Valentin Deniaud
<ul><li><strong>Statut</strong> changé de <i>Solution validée</i> à <i>Résolu (à déployer)</i></li></ul><pre>commit 3bfe24a4b6bdcb14ac1a8d9a275da05a37ec5328
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:42:28 2021 +0200
misc: fix deprecated-method pylint error (#56982)
commit 9babcb4b965c953df73f26d9a34b1c5a1cc58cd8
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:38:15 2021 +0200
misc: fix redundant-unittest-assert pylint error (#56982)
commit 0748fae9a16e62b90dc79a868776b04514cd8e44
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:36:10 2021 +0200
misc: fix f-string-without-interpolation pylint error (#56982)
commit 72723288032ea252347525e1cb866ab0b1be4ffb
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:35:53 2021 +0200
misc: fix logging-fstring-interpolation pylint error (#56982)
commit 61db86fffb56ea56095c5f96181c50f3b929df3c
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:34:33 2021 +0200
misc: fix logging-not-lazy pylint error (#56982)
commit be73f648c44ae0a4ef7a88a5f579c6b0f2d4fa4b
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:27:40 2021 +0200
misc: fix raising-format-tuple pylint error (#56982)
commit 19c5e7b1811a366f18a8f5d5188bd6f3077c013b
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:27:22 2021 +0200
misc: fix try-except-raise pylint error (#56982)
commit 8f9c967dee65e65c26da22b4dd63c2f2522bbd12
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:22:54 2021 +0200
misc: fix unbalanced-tuple-unpacking pylint error (#56982)
commit 292d6d3a78f682af7b8cd6c262899f24bd827c3a
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 15:08:50 2021 +0200
misc: fix unused-wildcard-import pylint error (#56982)
commit e0b86a7691ed0ce726c06e077c812fe8763ce920
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 12:12:58 2021 +0200
misc: fix unused-variable pylint error (#56982)
commit f3e5f4dab64ace3d8fe27f2fbea3eaacd307c715
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 12:08:47 2021 +0200
misc: fix unused-import pylint error (#56982)
commit d52fd290a3a9eedfdd654e94b466e784ae8f77e4
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:41:30 2021 +0200
misc: fix global-statement pylint error (#56982)
commit 0f93f4b0e8c279ca6f84766a47e0b806c3bea3cb
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:37:44 2021 +0200
misc: fix global-variable-not-assigned pylint error (#56982)
commit 647af66a5f290e72b2566259ad4d90abb4d151c6
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:31:27 2021 +0200
misc: fix reimported pylint error (#56982)
commit 3ed55f583a2d26a04c74e9a39b43c8207933548d
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:26:37 2021 +0200
misc: fix wildcard-import pylint error (#56982)
commit 3903a337a49ceda947c4da107855b1981d5ba627
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:26:03 2021 +0200
misc: fix arguments-renamed pylint error (#56982)
commit 31d68f072df36dad6de540b2e5c44865f803245d
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:07:25 2021 +0200
misc: fix useless-super-delegation pylint error (#56982)
commit eda115a0d5e80e08c8dd4f0ed75ac41708de86cf
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:07:06 2021 +0200
misc: fix comparison-with-callable pylint error (#56982)
commit b4c3bb96160d0824d0b80cef4a2b34c23e3412c0
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:05:20 2021 +0200
misc: fix eval-used pylint error (#56982)
commit 5624807d54797705d60bacce8335efa8c2e1c653
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:04:44 2021 +0200
misc: fix unnecessary-lambda pylint error (#56982)
commit d8553c5b910e55b30d3a4a94bb03503c77365c1c
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 11:00:34 2021 +0200
misc: fix unnecessary-pass pylint error (#56982)
commit 15436a68d9e180c9234cd0efa97c797e2c3b2100
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 10:59:49 2021 +0200
misc: fix pointless-string-statement pylint error (#56982)
commit 904dce7655186f1e61c5e96e0669db1a4f83fcfb
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 10:54:41 2021 +0200
misc: fix pointless-statement pylint error (#56982)
commit c5b69b9c41107f40a242d6cf492d89b5bfb08b28
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 10:46:40 2021 +0200
misc: fix dangerous-default-value pylint error (#56982)
commit b5b6fbdca04758f6496dac79f884daf678e7e19e
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 10:34:57 2021 +0200
misc: fix use-dict-literal pylint error (#56982)
commit 9d51d9809a5f132437741ccb99e99e08a2bf96ce
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue Sep 21 10:18:10 2021 +0200
misc: fix consider-using-with pylint error (#56982)
commit ea52280a07ce49c4752c794e29ab895dd02a71d5
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 18:08:03 2021 +0200
misc: fix no-else-continue pylint error (#56982)
commit d79c563c290ae182d8ac9720269966113ba43eb2
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 18:06:40 2021 +0200
misc: fix consider-using-in pylint error (#56982)
commit 19aaa8ab98cfadf1a16585e5fc0954a1783c4e19
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:38:53 2021 +0200
misc: fix no-else-break pylint error (#56982)
commit fdb8b20b5b877c5bf53f95ef36d701fe39882359
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:37:56 2021 +0200
misc: fix no-else-raise pylint error (#56982)
commit 2a8c063012c4b02fe548efb52f0ae7be22cc389f
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:36:13 2021 +0200
misc: fix consider-using-in pylint error (#56982)
commit 1af441661266deb0b3a819198ba128edce833a87
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:35:24 2021 +0200
misc: fix useless-return pylint error (#56982)
commit a4b9e51dc1aea8e0e18c525ddaf57847d1559078
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:35:04 2021 +0200
misc: fix consider-using-ternary pylint error (#56982)
commit 9fc2e2946486401c0001cc203f4f2e4bc9eeaea4
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:33:47 2021 +0200
misc: fix simplifiable-if-statement pylint error (#56982)
commit 8a26fc20d323ef2347eca0bb3f62f200e31830d9
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:31:46 2021 +0200
misc: fix consider-using-from-import pylint error (#56982)
commit 1a08018f84c2f93e5934aa66a18e6ebaf2eaf713
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:27:50 2021 +0200
misc: fix logging-too-many-args pylint error (#56982)
commit 2071defb19df27b3a545de5242ed14598e60bd3d
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:12:38 2021 +0200
misc: fix no-value-for-parameter pylint error (#56982)
commit 36a31d9d2af1bb9a765d9022ff0edf3162c662ee
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:00:45 2021 +0200
misc: fix assignment-from-no-return pylint error (#56982)
commit e2647e6481800cab408aa745e6960790d72ec156
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:48:38 2021 +0200
misc: fix undefined-variable pylint error (#56982)
commit b49ea2ea0cfdc136bbe6d2174c509c4f315daf70
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:34:29 2021 +0200
misc: fix used-before-assignment pylint error (#56982)
commit 9d7aa5d839f5afa6b7b8e7dcc1693bf5f45e51de
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:31:43 2021 +0200
misc: fix import-error pylint error (#56982)
commit 3e5fc8a89891541d8fbacfb99e96209c6aa76001
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:18:23 2021 +0200
misc: fix invalid-str-returned pylint error (#56982)
commit df66d77b6b47ac76cbcbb16933c37052ca99ebe0
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:09:15 2021 +0200
misc: fix no-self-argument pylint error (#56982)
commit e3adcd05583dc43c7153c4b2b7fb0316ad588e10
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:08:47 2021 +0200
misc: fix access-member-before-definition pylint error (#56982)
commit f4ae48c1bf55cb54b100830cc3e730b50aa258cc
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 15:01:44 2021 +0200
misc: fix function-redefined pylint error (#56982)
commit 2d0b05c5f9c6993f437863b04dfc76e4cb1cbd80
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:50:26 2021 +0200
misc: fix return-in-init pylint error (#56982)
commit 3b6cfa5146adb1fe57ed08e65cbc8d697e4b49f7
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:50:03 2021 +0200
misc: fix len-as-condition pylint error (#56982)
commit 2c5acd16bbfaa6a16ce97c05bac00b35391dc465
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:45:56 2021 +0200
misc: fix ungrouped-imports pylint error (#56982)
commit 7fd28d4c10cafe130466b8cb3a35a544da22af82
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:41:41 2021 +0200
misc: fix wrong-import-order pylint error (#56982)
commit f20fa532941fe9612cb1d0b41a3b145e44405982
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:41:14 2021 +0200
misc: fix line-too-long pylint error (#56982)
commit aabe4af2523c1a9560442318587cbf104c829360
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 14:31:10 2021 +0200
misc: fix consider-using-dict-items pylint error (#56982)
commit f3609da8f6cb139345e371cd1c133e0cc7eaa67e
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 12:26:29 2021 +0200
misc: fix bad-classmethod-argument pylint error (#56982)
commit fa778299640f2b16d75590c4f004540edcc1f1e4
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 11:54:11 2021 +0200
misc: fix unidiomatic-typecheck pylint error (#56982)
commit a47bce508603332b9af6a1853295e000d05dc22d
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 11:52:47 2021 +0200
misc: fix misplaced-comparison-constant pylint error (#56982)
commit 42f0a4361c6a04ad99a3be0478945d2b2578649b
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 11:51:08 2021 +0200
misc: fix singleton-comparison pylint error (#56982)
commit a2d8680e295745ff10698b1af7c9f59b3d651f9c
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 11:50:02 2021 +0200
misc: fix empty-docstrings pylint error (#56982)
commit 7406f4e9f0d8e03082138bfdcdab2d4706ded2b5
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:11:50 2021 +0200
decorators: remove broken and unused decorator (#56982)
commit 716a3599075b730b9dfa9d8dd0b8b2711e3c56ef
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Mon Sep 20 16:26:24 2021 +0200
tests: replace norequest decorator by explicit function (#56982)
commit e2079747b7cbe9ed8ea522117832effa56b76181
Author: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Thu Sep 16 16:45:27 2021 +0200
misc: update pylint configuration (#56982)</pre>
Authentic 2 - Development #56982: Faire planter le build sur les erreurs pylint
https://dev.entrouvert.org/issues/56982?journal_id=328844
2021-09-27T19:17:27Z
Frédéric Péters
fpeters@entrouvert.com
<ul><li><strong>Statut</strong> changé de <i>Résolu (à déployer)</i> à <i>Solution déployée</i></li></ul>