Project

General

Profile

Development #57268

Fix build with Python 3.10

Added by Jakub Hrozek 23 days ago. Updated 19 days ago.

Status:
Résolu (à déployer)
Priority:
Normal
Category:
-
Target version:
-
Start date:
24 Sep 2021
Due date:
% Done:

0%

Estimated time:
Patch proposed:
Yes
Planning:
No

Description

The attached patch was contributed by Miro Hroncok (miro at hroncok dot cz). It fixes lasso python bindings usage with py 3.10.


Files

Associated revisions

Revision a28fb8c8 (diff)
Added by Benjamin Dauvergne 19 days ago

Does not decref boolean constants (#57268)

TRUE/FALSE are special references in CPython bindings whose reference
count must never be updated.

History

#1

Updated by Benjamin Dauvergne 23 days ago

Could you state why you think the reference count is wrong here ?

#2

Updated by Jakub Hrozek 20 days ago

Benjamin Dauvergne a écrit :

Could you state why you think the reference count is wrong here ?

I'm sorry, but I don't have many more details than those that are in the RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1900651
The closes they came to an explanation is comment 18 (https://bugzilla.redhat.com/show_bug.cgi?id=1900651#c18)

#3

Updated by Benjamin Dauvergne 20 days ago

  • Assignee set to Benjamin Dauvergne
#4

Updated by Benjamin Dauvergne 20 days ago

Ok, I understood the issue but the patch applied to Fedora is wrong, the line should be kept for non-boolean constants.

Here is a better fix I think, could you check with downstream if they agree (maybe Simo).

#5

Updated by Benjamin Dauvergne 19 days ago

  • Status changed from Solution proposée to Résolu (à déployer)
commit a28fb8c8e1a01c7c226e016c91bef2e5b4436e23
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Mon Sep 27 14:14:23 2021 +0200

    Does not decref boolean constants (#57268)

    TRUE/FALSE are special references in CPython bindings whose reference
    count must never be updated.

Also available in: Atom PDF