Project

General

Profile

Development #57655

Faciliter le déplacement du block nav dans le thème

Added by Thomas Jund about 2 months ago. Updated about 1 month ago.

Status:
Solution déployée
Priority:
Normal
Assignee:
Target version:
-
Start date:
06 Oct 2021
Due date:
% Done:

0%

Estimated time:
Patch proposed:
Yes
Planning:
No

Description

Sur le modèle de ce qui a été fait pour le block user-info #52275 :

  • Ajouter un block `after_header`
  • Y positioner par défaut le block nav
  • déplacer le code de la nav dans son propre fichier `nav.html`

Files


Related issues

Blocked by Intégrations graphiques Publik - Development #57548: nouveau thème: MeudonSolution déployée04 Oct 2021

Actions

Associated revisions

Revision e363c89e (diff)
Added by Thomas Jund about 1 month ago

themes: easily move the nav block (#57655)

  • add block 'after-header'
  • move nav code into own file

Revision 58371583 (diff)
Added by Thomas Jund about 1 month ago

grenoble-metropole-2019: move nav template in own file (#57655)

Revision dd30f8f8 (diff)
Added by Thomas Jund about 1 month ago

villeurbanne-2018: move nav template in own file (#57655)

Revision e31ea169 (diff)
Added by Thomas Jund about 1 month ago

toulouse-metropole: move nav template in own file (#57655)

Revision 4c4b722e (diff)
Added by Thomas Jund about 1 month ago

cap-atlantique: move nav template in own file (#57655)

Revision ccbaeb1c (diff)
Added by Thomas Jund about 1 month ago

toulouse: move nav template in own file (#57655)

Revision fb0e57e2 (diff)
Added by Thomas Jund about 1 month ago

montlouis-sur-loire: move nav template in own file (#57655)

Revision cc59fa10 (diff)
Added by Thomas Jund about 1 month ago

la-baule: move nav template in own file (#57655)

Revision 16b8fbcf (diff)
Added by Thomas Jund about 1 month ago

haguenau: move nav template in own file (#57655)

Revision 0e543d14 (diff)
Added by Thomas Jund about 1 month ago

minint: restore nav (#57655)

Revision da84cd9e (diff)
Added by Thomas Jund about 1 month ago

toodego: move nav template in own file (#57655)

Revision bc46cd86 (diff)
Added by Thomas Jund about 1 month ago

braine-l-alleud: move nav template in own file (#57655)

Revision 2eef535b (diff)
Added by Thomas Jund about 1 month ago

montpellier: move nav template in own file (#57655)

Revision 188d9731 (diff)
Added by Thomas Jund about 1 month ago

clermont-ici: move nav template in own file (#57655)

History

#1

Updated by Thomas Jund about 2 months ago

Avertissement, ce patch supprime la navv présente par défaut dans theme.html (donc pour les plateformes qui n'utiliseraient pas combo). Je ne sais pas s'il y en a encore.
Je veux donc bien un premier retour sur ce patch avant de modifier les templates des thèmes.

#2

Updated by Serghei Mihai about 2 months ago

Il y a un besoin quelque part de déplacer la navigation?

#3

Updated by Thomas Jund about 2 months ago

Sur meudon, la nav est entre le logo et les #top-links.
Et sur pas mal d'autres thèmes, la nav est postionnée à coté du logo. Cette solution permet de proprement faire les choses: à coup de flexbox et order, plutôt que de jouer de manière hasardeuse à coup de position absolute ou de marge négatives.
Pierre a demandé il y a quelques mois de pouvoir le faire aussi sur une inté native, ce ticket ouvre la voie vers cette possibilité.

#4

Updated by Thomas Jund about 2 months ago

#5

Updated by Serghei Mihai about 2 months ago

  • Status changed from Solution proposée to Solution validée
#6

Updated by Thomas Jund about 2 months ago

  • Status changed from Solution validée to En cours

Merci Serghei.
Je patch les thèmes.

#7

Updated by Thomas Jund about 1 month ago

  • Status changed from En cours to Solution proposée

J'ai passé en revue tous les thèmes
code dispo dans la branch wip/57655-nav-block (1 commit par thème)
Il y a 14 thèmes modifiées, ce qui fait 14 commits, voilà pourquoi je ne post pas les patchs, mais si vous préférez…

#8

Updated by Frédéric Péters about 1 month ago

Si pour trouver ce qu'il faut modifier la commande est git grep 'block-menu' alors il y a des affaires aussi dans imio-publik-themes.

#9

Updated by Thomas Jund about 1 month ago

patch pour concarneau sur atreal-publik-theme

Concernant Imio, ce patch affecte les themes `site-liege` et `site-namur` qui me paraissent obsolète. J'ai ouvert un ticket specifique #57972 sur le projet imio.

#10

Updated by Serghei Mihai about 1 month ago

  • Status changed from Solution proposée to Solution validée

Corriger le message de commit pour Grenoble: s/genoble-metro/grenoble-metropole-2019/ et go.

#11

Updated by Thomas Jund about 1 month ago

  • Status changed from Solution validée to Résolu (à déployer)
commit 188d9731ff8a5f1ba9290dceb8e4edbb36f53902
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 17:34:27 2021 +0200

    clermont-ici: move nav template in own file (#57655)

commit 2eef535bfba2329fae5b4884227ed9f0c71c7e7c
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 17:31:24 2021 +0200

    montpellier: move nav template in own file (#57655)

commit bc46cd86a7c54e1439ca3dbd98bc3a53ace351db
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 17:15:56 2021 +0200

    braine-l-alleud: move nav template in own file (#57655)

commit da84cd9e95ef261b18dafe6d4cce8f19908b5c4a
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 16:52:44 2021 +0200

    toodego: move nav template in own file (#57655)

commit 0e543d142465c7017f0df278d9718af9d9674d8d
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 16:48:52 2021 +0200

    minint: restore nav (#57655)

commit 16b8fbcf2dab1e67e347979d1f3342735f6a864b
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 16:28:08 2021 +0200

    haguenau: move nav template in own file (#57655)

commit cc59fa10e0bb85281f6df0ef76455d8a90426bc5
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 16:19:19 2021 +0200

    la-baule: move nav template in own file (#57655)

commit 6e338c5eb42a6549e6dd6361c7d3a3c7732e320f
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 16:13:42 2021 +0200

    moselle: patch bad display of user-info block

commit fb0e57e231e1f7ac2029f4b1f9928ffbba96de5a
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 15:49:55 2021 +0200

    montlouis-sur-loire: move nav template in own file (#57655)

commit ccbaeb1cccd095bd83058c05c89882a74043621b
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 15:25:46 2021 +0200

    toulouse: move nav template in own file (#57655)

commit 4c4b722e293516beb90f7c84fd09253a3e68c78f
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 15:22:43 2021 +0200

    cap-atlantique: move nav template in own file (#57655)

commit e31ea169c0139afadf1a8333f4f024e4bdcf5830
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 15:14:49 2021 +0200

    toulouse-metropole: move nav template in own file (#57655)

commit dd30f8f8b769fc2e470a04135aeb7a6a88563417
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 15:05:05 2021 +0200

    villeurbanne-2018: move nav template in own file (#57655)

commit 583715832199f3ca3c9b08a48976014ab7be417c
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Mon Oct 18 14:43:33 2021 +0200

    grenoble-metropole-2019: move nav template in own file (#57655)

commit e363c89e7a2ed37ac0a962f3b89dfb05860931f1
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Wed Oct 6 16:32:27 2021 +0200

    themes: easily move the nav block (#57655)

    * add block 'after-header'
    * move nav code into own file
#12

Updated by Frédéric Péters about 1 month ago

  • Status changed from Résolu (à déployer) to Solution déployée
#13

Updated by Thomas Jund about 1 month ago

Dépot atreal-publik-themes

commit b8f89b9b71fc83683570a687958432cc73622a1a
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Tue Oct 19 11:45:18 2021 +0200

    concarneau: move nav template in own file (#57655)

Also available in: Atom PDF