Project

General

Profile

Development #64298

Publik - Project management #64274: montée de version django (→ 3.2 LTS)

django 3.2 vs {% skeleton_extra_placeholder %}

Added by Frédéric Péters 12 months ago. Updated 8 months ago.

Status:
Fermé
Priority:
Normal
Target version:
-
Start date:
18 April 2022
Due date:
% Done:

0%

Estimated time:
Patch proposed:
Yes
Planning:
No
Tags:

Description

Après django 2.2 il y a eu ce commit :

    commit 04ac9b45a34440fa447feb6ae934687aacbfc5f4
    Author: Alex Gaynor <alex.gaynor@gmail.com>
    Date:   Tue Oct 8 22:25:20 2019 -0400

        Improved performance of django.template.base.Parser.

        pop(0), which is used to fetch each token, is O(n) in the length of the
        list. By reversing the list and operating off the end, we can perform
        next_token(), prepend_token(), and delete_first_token() in constant
        time.

et comme skeleton_extra_placeholder fonctionne en partant d'une copie des tokens, le résultat produit n'est plus correct.


Files

Associated revisions

Revision 68e70703 (diff)
Added by Frédéric Péters 12 months ago

misc: adapt skeletontemplate tag for 3.2 (#64298)

This follows this django change:

commit 04ac9b45a34440fa447feb6ae934687aacbfc5f4
Author: Alex Gaynor <>
Date: Tue Oct 8 22:25:20 2019 -0400

Improved performance of django.template.base.Parser.
pop(0), which is used to fetch each token, is O(n) in the length of the
list. By reversing the list and operating off the end, we can perform
next_token(), prepend_token(), and delete_first_token() in constant
time.

History

#1

Updated by Frédéric Péters 12 months ago

Sans ajouter d'exécution des tests avec 3.2 dans jenkins pour le moment, en me disant que je vais sauver la planète en attendant qu'un calendrier de bascule puisse être envisagé.

#2

Updated by Thomas Noël 12 months ago

  • Status changed from Solution proposée to Solution validée

Ack, quoique je n'ai rien vu dans le programme des Verts contre le pop(0). Un oubli, sans doute.

#3

Updated by Frédéric Péters 12 months ago

  • Status changed from Solution validée to Résolu (à déployer)
commit 68e707037715de67dc38e8cc4ac9c41cabd6ad7c
Author: Frédéric Péters <fpeters@entrouvert.com>
Date:   Mon Apr 18 11:29:31 2022 +0200

    misc: adapt skeletontemplate tag for 3.2 (#64298)

    This follows this django change:

    commit 04ac9b45a34440fa447feb6ae934687aacbfc5f4
    Author: Alex Gaynor <alex.gaynor@gmail.com>
    Date:   Tue Oct 8 22:25:20 2019 -0400

        Improved performance of django.template.base.Parser.

        pop(0), which is used to fetch each token, is O(n) in the length of the
        list. By reversing the list and operating off the end, we can perform
        next_token(), prepend_token(), and delete_first_token() in constant
        time.
#4

Updated by Transition automatique 12 months ago

  • Status changed from Résolu (à déployer) to Solution déployée
#5

Updated by Transition automatique 10 months ago

Automatic expiration

#6

Updated by Agate (Absente jusqu'au 12/04/2023) 8 months ago

  • Parent task set to #64274

Also available in: Atom PDF