Project

General

Profile

Bug #6805

Give all password requirements at once

Added by Frédéric Péters over 4 years ago. Updated over 1 year ago.

Status:
Fermé
Priority:
Normal
Category:
-
Target version:
Start date:
24 Mar 2015
Due date:
% Done:

100%

Patch proposed:
Yes
Planning:
No

Description

It is frustrating to enter a password that is too short, receive a message that it must be at least n characters long, type a new one, and get another refusal because it doesn't contain the appropriate classes of characters. Password requirements should all be displayed at once.

Related upstream django discussion: https://groups.google.com/forum/#!topic/django-developers/9GBhgGXmEKs

0001-report-all-password-requirements-at-once-on-password.patch View (5.94 KB) Benjamin Dauvergne, 24 Mar 2015 04:52 PM

0002-update-french-translations-6805.patch View (25.1 KB) Benjamin Dauvergne, 24 Mar 2015 04:52 PM

0001-report-all-password-requirements-at-once-on-password.patch View (6.1 KB) Benjamin Dauvergne, 31 Mar 2015 04:06 PM

0002-update-french-translations-6805.patch View (25.3 KB) Benjamin Dauvergne, 31 Mar 2015 04:06 PM

Associated revisions

Revision 00d4fac3 (diff)
Added by Benjamin Dauvergne about 4 years ago

report all password requirements at once on password input (fixes #6805)

Revision ba9e8bd6 (diff)
Added by Benjamin Dauvergne about 4 years ago

update french translation (#6805)

History

#1 Updated by Benjamin Dauvergne over 4 years ago

#2 Updated by Frédéric Péters over 4 years ago

Perhaps "Your password must match the regular expression: %(regexp)s'" will prevent people from even trying to enter a password, I would leave that one out. I would also maybe s/Your password/The password/ in the message.

#3 Updated by Benjamin Dauvergne over 4 years ago

The regexp message is here to recall people that they must set custom message through app_settings.A2_PASSWORD_POLICY_REGEX_ERROR_MSG, it is not meant for real user consumption. If you prefer I could just add a check that the two settings are defined using the new setting checks from Django 1.7 and crashing on launch.

#4 Updated by Benjamin Dauvergne over 4 years ago

Benjamin Dauvergne a écrit :

The regexp message is here to recall people that they must set custom message through app_settings.A2_PASSWORD_POLICY_REGEX_ERROR_MSG, it is not meant for real user consumption. If you prefer I could just add a check that the two settings are defined using the new setting checks from Django 1.7 and crashing on launch.

I reminded me that it will not work with a multitenant deployment as I cannot check tenant settings.

#5 Updated by Benjamin Dauvergne over 4 years ago

  • Target version set to 2.2.0

#6 Updated by Benjamin Dauvergne over 4 years ago

Message changed for :

+"Your password must match the regular expression: %(regexp)s, please change " 
+"this message using the A2_PASSWORD_POLICY_REGEX_ERROR_MSG setting." 

#7 Updated by Frédéric Péters over 4 years ago

  • Status changed from Nouveau to En cours

ack.

#8 Updated by Benjamin Dauvergne over 4 years ago

  • Status changed from En cours to Rejeté

#9 Updated by Benjamin Dauvergne over 4 years ago

  • Status changed from Rejeté to Nouveau

#10 Updated by Frédéric Péters about 4 years ago

I'm still fine with it but the patch no longer apply.

#11 Updated by Benjamin Dauvergne about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Nouveau to Résolu (à déployer)

#12 Updated by Benjamin Dauvergne over 3 years ago

  • Status changed from Résolu (à déployer) to Solution déployée

#13 Updated by Benjamin Dauvergne over 1 year ago

  • Status changed from Solution déployée to Fermé

Also available in: Atom PDF