Bug #7386
custom user fields appear on profile edit page even if not set as user_visible and editable
Start date:
27 May 2015
Due date:
% Done:
0%
Estimated time:
Patch proposed:
Yes
Planning:
Files
Associated revisions
History
Updated by Benjamin Dauvergne over 7 years ago
- Assignee set to Serghei Mihai
- Target version set to 2.2.0
Updated by Serghei Mihai over 7 years ago
- File 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch added
- Patch proposed changed from No to Yes
Updated by Serghei Mihai over 7 years ago
- File 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch added
Updated patch with tests
Updated by Benjamin Dauvergne over 7 years ago
I'm not sure of that:
self.assertFalse(set(form.fields), set(['national_number', 'custom']))
Updated by Serghei Mihai over 7 years ago
If there are no other user fields to edit(like first and last name) the only possible fields to edit could be national_number
and custom
.
And in default config there are no other fields.
So I check if both fields do not appear if the form.
Updated by Serghei Mihai over 7 years ago
After discussion with Benjamin I prefer check the fields presence with:
self.assertNotIn('national_number', form.fields) self.assertNotIn('custom', form.fields)
Updated by Serghei Mihai over 7 years ago
- File 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch 0001-fix-displaying-custom-user-attributes-in-forms-7386.patch added
Finally one single assertEqual
Depends of #7391
Updated by Serghei Mihai over 7 years ago
- Status changed from Nouveau to Résolu (à déployer)
commit 53a7ce694e3215dcb872dccf52dbe84a870d172a Author: Serghei Mihai <smihai@entrouvert.com> Date: Fri May 29 11:51:57 2015 +0200 fix displaying custom user attributes in forms (#7386)
Updated by Benjamin Dauvergne almost 7 years ago
- Status changed from Résolu (à déployer) to Solution déployée
fix displaying custom user attributes in forms (#7386)