Bug #7612
NameIDPolicy is optional
100%
Description
Line 504 of saml2_endpoints.py try to dump the NameIDPolicy node of AuthnRequest uncondtionnaly, as this element is optional, this is a bug.
Files
Related issues
Associated revisions
Revert "Do not unconditionnaly dump the NameIDPolicy node as it is optional (#7612)"
This reverts commit fde8ff574fa83268aa79566b1d80944998efb8e9.
NameIDPolicy is optional in AuthnRequest (fixes #7612)
History
Updated by Benjamin Dauvergne over 5 years ago
- File 0001-Do-not-unconditionnaly-dump-the-NameIDPolicy-node-as.patch 0001-Do-not-unconditionnaly-dump-the-NameIDPolicy-node-as.patch added
- Patch proposed changed from No to Yes
Updated by Ritesh Patel over 5 years ago
after the above patch, it seems error happens on line 525 in src/authentic2/idp/saml/saml2_endpoints.py.
if you fix line 525, then it complains on line 706.
I think if no NameIDPolicy found in request, then we should assign the default which will fix the issue.
Updated by Benjamin Dauvergne over 5 years ago
- Status changed from Nouveau to Résolu (à déployer)
- % Done changed from 0 to 100
Appliqué par commit authentic2|fde8ff574fa83268aa79566b1d80944998efb8e9.
Updated by Benjamin Dauvergne over 5 years ago
- Status changed from Résolu (à déployer) to Nouveau
- % Done changed from 100 to 0
Patch did not fix the problem.
Updated by Benjamin Dauvergne over 5 years ago
- Status changed from Nouveau to Résolu (à déployer)
- % Done changed from 0 to 100
Appliqué par commit authentic2|66e4d0f70b9c9938eb42cc6a79e79b33a9183ab4.
Updated by Benjamin Dauvergne about 5 years ago
- Status changed from Résolu (à déployer) to Solution déployée
Do not unconditionnaly dump the NameIDPolicy node as it is optional (fixes #7612)