Project

General

Profile

Bug #7612

NameIDPolicy is optional

Added by Benjamin Dauvergne about 4 years ago. Updated over 1 year ago.

Status:
Fermé
Priority:
Normal
Category:
-
Target version:
Start date:
17 Jun 2015
Due date:
% Done:

100%

Patch proposed:
Yes
Planning:
No

Description

Line 504 of saml2_endpoints.py try to dump the NameIDPolicy node of AuthnRequest uncondtionnaly, as this element is optional, this is a bug.

0001-Do-not-unconditionnaly-dump-the-NameIDPolicy-node-as.patch View (1.29 KB) Benjamin Dauvergne, 17 Jun 2015 09:18 PM


Related issues

Related to Authentic 2 - Bug #8061: mimecast support Fermé 17 Aug 2015

Associated revisions

Revision fde8ff57 (diff)
Added by Benjamin Dauvergne about 4 years ago

Do not unconditionnaly dump the NameIDPolicy node as it is optional (fixes #7612)

Revision 33abc5bf (diff)
Added by Benjamin Dauvergne about 4 years ago

Revert "Do not unconditionnaly dump the NameIDPolicy node as it is optional (#7612)"

This reverts commit fde8ff574fa83268aa79566b1d80944998efb8e9.

Revision 66e4d0f7 (diff)
Added by Benjamin Dauvergne about 4 years ago

NameIDPolicy is optional in AuthnRequest (fixes #7612)

History

#1 Updated by Benjamin Dauvergne about 4 years ago

#2 Updated by Ritesh Patel about 4 years ago

after the above patch, it seems error happens on line 525 in src/authentic2/idp/saml/saml2_endpoints.py.

if you fix line 525, then it complains on line 706.

I think if no NameIDPolicy found in request, then we should assign the default which will fix the issue.

#3 Updated by Benjamin Dauvergne about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Nouveau to Résolu (à déployer)

#4 Updated by Benjamin Dauvergne about 4 years ago

  • Status changed from Résolu (à déployer) to Nouveau
  • % Done changed from 100 to 0

Patch did not fix the problem.

#5 Updated by Benjamin Dauvergne about 4 years ago

  • Status changed from Nouveau to Résolu (à déployer)
  • % Done changed from 0 to 100

#6 Updated by Frédéric Péters about 4 years ago

  • Related to Bug #8061: mimecast support added

#7 Updated by Benjamin Dauvergne over 3 years ago

  • Status changed from Résolu (à déployer) to Solution déployée

#8 Updated by Benjamin Dauvergne over 1 year ago

  • Status changed from Solution déployée to Fermé

Also available in: Atom PDF