Project

General

Profile

Bug #8327

silent asserts produce a gettext header

Added by Frédéric Péters about 4 years ago. Updated about 2 years ago.

Status:
Fermé
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
23 Sep 2015
Due date:
% Done:

100%

Patch proposed:
No
Planning:
No

Description

log_assert() got it and a message got displayed but since the string was empty it was replaced by the gettext header (see capture).

I'd suggest a change of this kind:

-            return error_redirect(request, e.message)
+            return error_redirect(request, e.message or repr(e))

Capture d_écran 2015-09-23 à 11.24.41.png View (163 KB) Frédéric Péters, 23 Sep 2015 11:43 AM

7867

Associated revisions

Revision 6c2665d4 (diff)
Added by Benjamin Dauvergne about 4 years ago

idp/saml2: prevent silent asserts from producing producing a gettext header (fixes #8327)

error_redirect() pass its msg argument to gettext, if msg is empty,
gettext header is returned.

History

#2 Updated by Benjamin Dauvergne about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Nouveau to Résolu (à déployer)

#3 Updated by Benjamin Dauvergne about 4 years ago

  • Target version set to 2.2.0

#4 Updated by Benjamin Dauvergne almost 4 years ago

  • Status changed from Résolu (à déployer) to Solution déployée

#5 Updated by Benjamin Dauvergne about 2 years ago

  • Status changed from Solution déployée to Fermé

Also available in: Atom PDF