Project

General

Profile

Development #8826

Refactoring: merge LibertyServiceProvider into LibertyProvider

Added by Benjamin Dauvergne about 8 years ago. Updated over 4 years ago.

Status:
En cours
Priority:
Normal
Assignee:
-
Category:
-
Target version:
2.2.0
Start date:
30 October 2015
Due date:
% Done:

0%

Estimated time:
Patch proposed:
No
Planning:
No

Description

There is no need for two models anymore, all fields from LibertyServiceProvider could be carried by LibertyProvider.

  • First a migration should add new field to LibertyProvider mapping those of LibertyServiceProvider with null=True for those lacking it
  • Second a migration should copy all value from LibertyServiceProvider to their liberty_provider
  • Third all use of LibertyServiceProvider should be changed to use directly LibertyProvider
  • Finally the LibertyServiceProvider model should be removed

Files

liberty_service_provider-to-service_provider-8826.patch (16.5 KB) liberty_service_provider-to-service_provider-8826.patch Josué Kouka, 11 December 2015 03:27 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-Libe.patch (14.8 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-Libe.patch Josué Kouka, 16 December 2015 05:44 PM
0001-authentic2-saml-forms-remove-self.childs-there-are-n.patch (1.72 KB) 0001-authentic2-saml-forms-remove-self.childs-there-are-n.patch Benjamin Dauvergne, 18 December 2015 12:21 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-Libe.patch (20.6 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-Libe.patch Josué Kouka, 21 December 2015 11:56 AM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (21.3 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 21 December 2015 10:42 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (21.7 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 21 December 2015 11:26 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (23.2 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 11 March 2016 06:05 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (23.4 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 16 March 2016 05:30 PM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (23.4 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 17 March 2016 10:46 AM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (23.3 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 17 March 2016 10:56 AM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (23.2 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 17 March 2016 11:00 AM
0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch (24.3 KB) 0001-Model-Data-migrations-of-LibertyServiceProvider-to-L.patch Josué Kouka, 05 April 2016 10:13 AM

Related issues

Related to Publik - Project management #10245: Gérer les autorisations de se connecter à un service dans authenticFermé09 March 2016

Actions
Related to Hobo - Bug #10466: merge des classes A2 LibertyServiceProvider et LibertyProviderEn cours29 March 2016

Actions
Related to Authentic 2 - Development #76893: logguer sur un service SAML incomplet (et/ou revoir les modèles pour que ça n'arrive pas ?)Nouveau22 April 2023

Actions

History

#1

Updated by Josué Kouka about 8 years ago

  • Status changed from Nouveau to En cours
#2

Updated by Benjamin Dauvergne almost 8 years ago

  • Target version set to 2.2.0
#4

Updated by Benjamin Dauvergne almost 8 years ago

Je n'arrive plus à appliquer le patch sur master, pourrais-tu le rebaser ?

#5

Updated by Josué Kouka almost 8 years ago

Pour te remettre dans le contexte, l'erreur survenait dans src/authentic2/saml/models.py ligne 34. lasso.Provider

#6

Updated by Benjamin Dauvergne almost 8 years ago

Patch to remove last traces of handling of LibertyServiceProvider in authentic2/saml/forms.py, the form should be refactored as a ModelForm to remove the need to implement def save().

#9

Updated by Josué Kouka almost 8 years ago

References to LibertyServiceProvider removed from common.py

#10

Updated by Josué Kouka almost 8 years ago

fix FieldError: Relation fields do not support nested lookups

#11

Updated by Benjamin Dauvergne over 7 years ago

  • authentic2/saml/admin.py remove commented lines, move enabled up in the fieldset, rename fieldset title "SAML service provider" to "Policy"
  • authentic2/saml/forms.py there is an akward raise added before another
  • saml/management/commands/sync-metadata.py reformat the docstring et remove reference LibertyIdentityProvider in it, the expressed not options['create-disabled'] must not be removed but applied to LibertyProvider.enabled
  • src/authentic2/saml/migrations/0018_auto_20151208_1542.py you need to provied an empty backward RunPython migration like def noop(apps, schema_editor): pass, see other RunPython migrations in authentic
  • src/authentic2/saml/migrations/0020_auto_20151221_1108.py a RunPython is missing

The you will need to rebase, for testing migrations I advise loading a dump of Montpellier production database and see if it works.

#12

Updated by Benjamin Dauvergne over 7 years ago

#13

Updated by Josué Kouka over 7 years ago

Everything seems to be alright. Tested with 3m production db

#14

Updated by Benjamin Dauvergne over 7 years ago

the expressed not options['create-disabled'] must not be removed but applied to LibertyProvider.enabled

This request is not treated.

The noop() operation is not plugged in the RunPython action in migration 0018 and 0020.

#17

Updated by Benjamin Dauvergne over 7 years ago

Pour le RunPython, s'il te plait, lis la doc.

#19

Updated by Josué Kouka over 7 years ago

Benjamin Dauvergne a écrit :

Pour le RunPython, s'il te plait, lis la doc.

Ah oui, c'est

RunPython(FowardFunc, RewardFun)
#21

Updated by Benjamin Dauvergne over 7 years ago

Il faudrait modifier aussi la commande hobo/agent/authentic2/management/commands/hobo_deploy.py, il y a aussi des mentions de LibertyServiceProvider dans le dépôt authentic2-pratic.git. J'ai fait un grep sur tous les repos je n'en vois pas d'autres (il y a en dans portial-citoyen.git mais ce projet est mort).

#22

Updated by Josué Kouka over 7 years ago

  • Related to Bug #10466: merge des classes A2 LibertyServiceProvider et LibertyProvider added
#23

Updated by Josué Kouka over 7 years ago

Ajout de la gestion de dépendances avec hobo pour authentic2-multitenant

#24

Updated by Benjamin Dauvergne about 6 years ago

  • Patch proposed changed from Yes to No

Ce serait vraiment sympa d'intégrer ça à un moment, mais faut rebaser je pense.

#25

Updated by Frédéric Péters over 4 years ago

  • Assignee deleted (Josué Kouka)
#26

Updated by Frédéric Péters 7 months ago

  • Related to Development #76893: logguer sur un service SAML incomplet (et/ou revoir les modèles pour que ça n'arrive pas ?) added

Also available in: Atom PDF