Bug #90933: action commentaire, avec un templatetag for sur un LazyField qui vaut None (TypeError: 'NoneType' object is not iterable) - w.c.s. - Redmine Entr’ouvert

Bug #90933

action commentaire, avec un templatetag for sur un LazyField qui vaut None (TypeError: 'NoneType' object is not iterable)

Added by Sentry Io about 1 year ago. Updated about 1 year ago.

Status:

Fermé

Priority:

Normal

Assignee:

Frédéric Péters

Target version:

Start date:

22 May 2024

Due date:

% Done:

Estimated time:

Patch proposed:

Planning:

Description

https://sentry.entrouvert.org/entrouvert/publik/issues/126447/

TypeError: 'NoneType' object is not iterable
(19 additional frame(s) were not displayed)
...
  File "django/template/base.py", line 162, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "django/template/defaulttags.py", line 182, in render
    for i, item in enumerate(values):
  File "wcs/variables.py", line 1404, in __iter__
    return iter(self.get_value())

Associated revisions

Revision 427fcf9e (diff)
Added by Frédéric Péters about 1 year ago

misc: do not iter on empty items (#90933)

History

Updated by Lauréline Guérin about 1 year ago

Project changed from Suivi des traces to w.c.s.

Updated by Lauréline Guérin about 1 year ago

Subject changed from actio commentaire, avec un templatetag for sur un LazyField qui vaut None (TypeError: 'NoneType' object is not iterable) to action commentaire, avec un templatetag for sur un LazyField qui vaut None (TypeError: 'NoneType' object is not iterable)

Updated by Frédéric Péters about 1 year ago

Assignee set to Frédéric Péters

<p>{% for service in form_var_software %}{{ service.code }}{% endfor %}</p>

le crash est curieux, je n'arrive pas à capter le contexte précis, sur une liste vide, on ne devrait pas aller jusque là,

        with context.push():
            values = self.sequence.resolve(context, ignore_failures=True)
            if values is None:
                values = []
            if not hasattr(values, '__len__'):
                values = list(values)
            len_values = len(values)
            if len_values < 1:
                return self.nodelist_empty.render(context)

il y a même déjà un test pour vérifier que ça passe :

        # test iterating on None value
        tmpl = Template('a{% for x in form_var_plop3 %}{{x}}{% endfor %}b')
        assert tmpl.render(context) == 'ab'