Produits Entr'ouvert » Authentic 2

Bad news https://github.com/kennethreitz/tablib/issues/19

I think the only way forward would be to rewrite the ODS export using equivalent w.c.s. code. generating XML files directly.

Strangely the implementation in tablib at the date of the issue does not use openpyxl for ods export at all...

Completely strange behaviour:

In [14]: %timeit -n1 -r1 tablib.Dataset(*[(i,i) for i in range(1000)]).ods
1 loops, best of 1: 3.55 s per loop

In [15]: %timeit -n1 -r1 tablib.Dataset(*[(i,) for i in range(1000)]).ods
1 loops, best of 1: 297 ms per loop

But the code is just ugly¹, it even seems false ( ws.addElement(table.TableColumn()) done on each row of each column ?!?).

¹ https://github.com/kennethreitz/tablib/blob/develop/tablib/formats/_ods.py#L54

Big improvement:

--- /usr/lib/python2.7/dist-packages/tablib/formats/_ods.py    2014-10-13 23:44:09.000000000 +0200
+++ /tmp/_ods.py    2016-01-22 18:47:32.346140742 +0100
@@ -68,33 +68,18 @@
             except TypeError:
                 ## col is already unicode
                 pass
-            ws.addElement(table.TableColumn())

             # bold headers
             if (row_number == 1) and dataset.headers:
                 odf_row.setAttribute('stylename', bold)
-                ws.addElement(odf_row)
                 cell = table.TableCell()
                 p = text.P()
                 p.addElement(text.Span(text=col, stylename=bold))
                 cell.addElement(p)
                 odf_row.addElement(cell)
-
             # wrap the rest
             else:
-                try:
-                    if '\n' in col:
-                        ws.addElement(odf_row)
-                        cell = table.TableCell()
-                        cell.addElement(text.P(text=col))
-                        odf_row.addElement(cell)
-                    else:
-                        ws.addElement(odf_row)
                         cell = table.TableCell()
                         cell.addElement(text.P(text=col))
                         odf_row.addElement(cell)
-                except TypeError:
                     ws.addElement(odf_row)
-                    cell = table.TableCell()
-                    cell.addElement(text.P(text=col))
-                    odf_row.addElement(cell)

It seems that tablib and/or ods export have never been really used...

It still takes more thant 1Go of memory to build the ODS and the gunicorn worker is killed :/