Revert "improve/tidy up interfaces widget"
I pushed it accidentally, will wait a fixed version of the patch
This reverts commit b75192e3bc851e80d6bfd33c12849dbc269039fb.
Merge pull request #1259 from CharlieMarshall/improveInter
improve/tidy up interfaces widget
Add missing s to solve the issue reported on https://forum.pfsense.org/index.php?topic=80722.new#new
Move the fetching of a package's config file and additional files to separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing.
fix gold alignment and redirect
Revert "make gold link more visable"
This reverts commit a03943d203441a87ea9c01f383d451dfc921bdd2.
make gold link more visable
Do this check now that hash algos can be empty
Correct the ipsec status pages to show proper information as needed.
Use proper path to setkey now that ipsec-tools are not used anymore
Correct the functions for returning tunnel status to use strongswan status reports
Allow HASH algorithms to be empty for phase2 in case the encryption one is AES-GCM
Ensure this is always an array to avoid a PHP error from foreach.
Do not reset source and destination port range values when it's an associated rule created by nat port forward. It fixes #3778
Require click-through POST confirmation when restoring or deleting a configuation from the backup history page.
Do not execute DNS resolution on GET, only pre-fill Host box so the user can press the button to execute. Turn alias creation links into submit buttons for POST. While here, remove some backticks and simplify a little.
Shorten the wait at "reload" in startup wizard to 5 seconds from 60. That's more than adequate for current systems, no need to make people sit there for 1 minute. Many likely click out via the logo and miss the last screen entirely.
Change the logic of the vpn config generation to make connectivity more stable especially ipsec. Also for IKEv1 just generate the policies and only on traffic start them.
Encode interface/VIP descriptions before displaying them on the NTP daemon settings.
Encode interface/VIP descriptions before displaying them on the GRE and GIF pages also;While here, the GRE page was missing IP aliases from its list of bind IPs, add it in.
Encode the detail field of an alias entry before displaying its contents back to the user.
Escape the individual dnsmasq advanced/custom options
Allow to add ipalias vip to lo0, it should fix #3773
Use GPS type presets only to pre-set values then user can change it. After user changes, save type always as Custom to avoid overwriting values when user attempt to edit. It fixes #3782
More non-functional changes to make code more readable
Fix indent and spaces
This if is unecessary since input_errors is unset in the line above
Fix indent and whitespaces
Make sure there are not empty options on dst select to avoid creating empty user or group. This issue was introduced by b4e9a4da
Fix select name
Fix input validation logic on diag_testport.php, escape more shell arguments for good measure
Fix #3790. Fix IPv6 Prefix ID check using interface user choose before save
Use a uniqid() to track phase2 entries to avoid confustion and various mistakes when modifying and editing them.
Add message about Gold to setup wizard and menu/link to Gold signup.
Fix #3575, do not allow user to set IPs for GRE interfaces on interface edit page.
Fix redirect after editing permissions
Disable bandwidth checks for PRIQ, it should fix #3537
Fix field name that cannot contain spaces, and use displayname
Fix scheduler field name
Fix field name
Strict checks for number of WANs and LANs on wizard
Fix number of WAN / LAN interfaces detection for dedicated wizard
Try to guess number of WANs
Try to guess number of WANs and LANs
Fix number of WAN and LAN connections check
Just show right type of interfaces (LAN/WAN) on traffic shapper wizards, it fixes #3535
Remove 'multi lan/single wan' and 'multi wan/single lan' traffic shaper wizards, multi lan/wan can be used to replace any of them
Replace exec() and system() calls by internal functions
Use SERVER_NAME instead of HTTP_HOST env var, it doesn't have port, then it avoids wizard end point to wrong IPv6 address. It should fix #3550
System: Firmware: Settings
Updater Settings Tabsystem_firmware_settings.php
Line 488, Column 43: value of attribute "type" cannot be "input"; must be one of "text", "password", "checkbox", "radio", "submit", "reset", "file", "hidden", "image", "button"...
Merge pull request #1232 from N0YB/Widget_Gateways
Merge pull request #1235 from N0YB/Mixed_Case_Hostname
Merge pull request #1236 from N0YB/Widget_Services_Status
Merge pull request #1237 from N0YB/XHTML_Compliance_System_Menu
Review all parameters on unbound main GUI, fix boolean params and add missing ones. Also make it work properly with 'apply'
Use the apply trigger for unbound acls to avoid restart unbound every time
Some GUI tweaks on unbound main screen
Improve unbound ACL edit page to use correct classes and jquery.ipv4v6ify.js
Fix acl item removal
Few GUI tweaks on unbound ACL page
Fix multiple issues on unbound advanced options GUI:
- Drop many wrong key assignments to pconfig- Add missing keys to pconfig- Deal fine with boolean parameters- Mark subsystem dirty to require apply button- Drop calls to enable_change()- Remove unecessary js function enable_change()...
Allow hostnames in bulk import since they are valid entries in a network type alias.
Merge pull request #1242 from ExolonDX/branch_master_01
Fix PHP script closing tag placement.
Convert almost all /sbin/sysctl calls to php functions
Fix indent
Add missing $g to global, as noted on pull request 1249
Change Cancel button to call history.back() as done in Firewall Rules, the current method has issues with IE 11, it should fix #3728
Also check and verify the package server's SSL certificate if using HTTPS. Issue 484Our current XMLRPC client version doesn't have support on its own to validate this in a way we can use to test in a usable for printing an error message. For now, a cURL query to the XMLRPC URL is used in its place.
More refinements to the unofficial package repository warning ( Issue #484 ) -- Now also shows on Dashboard and installed package list. Cleaned up some code and shuffled things around to avoid unnecessary repetition.
Detect if an unofficial package repository is in use and warn the user. Part of issue #484 (more to go)
Stop calling auto_login() here since it's already called inside setup_serial_port()
Fix #3725:
- Fix match_filter_field() and also simplify logic- Fix $filterfieldsarray initialization- Avoid to have double spaces on filterfieldsarray['act']- Fix filter on Firewall Logs
Set default serial speed to 115200 for 2.2, fixes #3715
Merge pull request #1238 from DasTestament/master
Update vpn_openvpn_server.php
Update vpn_openvpn_client.php
Merge pull request #1241 from Gertjanpfsense/master
Fix dscp values and provide a config upgrade to fix values stored in config.xml. This is a proper fix for #3688
Tidy up misc. XHTML
"diag_dns.php" Tidy up "equals sign"
"services_captiveportal.php" Add space to OPTION tagUpdate HTML Boolean operatorClose INPUT and BR tags
"services_captiveportal_hostname.php" Update ALIGN to MIDDLE
"services_captiveportal_vouchers.php"...
Update status_captiveportal.php
Don't ask to select a zone if there is only ONE.
oops, that wasn't supposed to be removed.
Use count($array) where applicable, instead of a $rowIndex increment.
removed comments
Merge pull request #1218 from razzfazz/nat_add_missing_protocols_master
Remove also . and / from graph
Remove more backticks
Fix status_rrd_graph_img.php and also improve it:
- Remove escapeshellarg that broke command line- Only remove dangerous chars to avoid command injection- Replace all `hostname` calls by php_uname('n')- Replace all `date` calls by strftime()- Add $_gb to collect possibly garbage from exec return
Make sure single quotes are encoded and avoid javascript injection
Simplify logic, add some protection to user input parameters
Fix whitespaces and indent
We need to allow subdirectories under /usr/local/pkg, here is the proper fix