0001-general-check-responses-for-required-attributes-as-1.patch

Frédéric Péters, 09 mars 2016 22:32

Voir les différences: en ligne côte à côte

Subject: [PATCH] general: check responses for required attributes as 1st
 processing step (#9729)

 eopayment/__init__.py    | 3 ++-
 eopayment/common.py      | 4 ++++
 eopayment/dummy.py       | 4 +++-
 eopayment/ogone.py       | 5 ++++-
 eopayment/paybox.py      | 4 +++-
 eopayment/sips.py        | 4 +++-
 eopayment/sips2.py       | 8 ++++----
 eopayment/spplus.py      | 4 +++-
 eopayment/systempayv2.py | 5 ++++-
 eopayment/tipi.py        | 4 +++-
 tests/test_ogone.py      | 8 ++++++++
 11 files changed, 41 insertions(+), 12 deletions(-)

     # -*- coding: utf-8 -*-
     from common import URL, HTML, FORM, RECEIVED, ACCEPTED, PAID, DENIED, CANCELED, CANCELLED, ERROR
     from common import (URL, HTML, FORM, RECEIVED, ACCEPTED, PAID, DENIED,
                         CANCELED, CANCELLED, ERROR, ResponseError)
     __all__ = ['Payment', 'URL', 'HTML', 'FORM', 'SIPS',
     'SYSTEMPAY', 'SPPLUS', 'TIPI', 'DUMMY', 'get_backend', 'RECEIVED', 'ACCEPTED',

     ORDERID_TRANSACTION_SEPARATOR = '!'
     class ResponseError(Exception):
         pass
     class PaymentResponse(object):
         '''Holds a generic view on the result of payment transaction response.

     except ImportError:
         from urlparse import parse_qs
     from common import PaymentCommon, URL, PaymentResponse, PAID, ERROR
     from common import PaymentCommon, URL, PaymentResponse, PAID, ERROR, ResponseError
     __all__ = [ 'Payment' ]
-...
         def response(self, query_string, logger=LOGGER, **kwargs):
             form = parse_qs(query_string)
             if not 'transaction_id' in form:
                 raise ResponseError()
             transaction_id = form.get('transaction_id',[''])[0]
             form[self.BANK_ID] = transaction_id

     from decimal import Decimal, ROUND_HALF_UP
     from common import (PaymentCommon, PaymentResponse, FORM, CANCELLED, PAID,
             ERROR, Form, DENIED, ACCEPTED, ORDERID_TRANSACTION_SEPARATOR)
             ERROR, Form, DENIED, ACCEPTED, ORDERID_TRANSACTION_SEPARATOR,
             ResponseError)
     def N_(message): return message
     ENVIRONMENT_TEST = 'TEST'
-...
         def response(self, query_string, **kwargs):
             params = urlparse.parse_qs(query_string, True)
             params = dict((key.upper(), params[key][0]) for key in params)
             if not set(params) >= set(['ORDERID', 'PAYID', 'STATUS', 'NCERROR']):
                 raise ResponseError()
             reference = params['ORDERID']
             transaction_id = params['PAYID']
             status = params['STATUS']

     import warnings
     from common import (PaymentCommon, PaymentResponse, FORM, PAID, ERROR, Form,
             ORDERID_TRANSACTION_SEPARATOR)
             ORDERID_TRANSACTION_SEPARATOR, ResponseError)
     __all__ = ['sign', 'Payment']
-...
         def response(self, query_string, callback=False, **kwargs):
             d = urlparse.parse_qs(query_string, True, False)
             if not set(d) >= set(['erreur', 'reference']):
                 raise ResponseError()
             signed = False
             if 'signature' in d:
                 sig = d['signature'][0]

     import uuid
     import warnings
     from common import PaymentCommon, HTML, PaymentResponse
     from common import PaymentCommon, HTML, PaymentResponse, ResponseError
     from cb import CB_RESPONSE_CODES
     '''
-...
         def response(self, query_string, **kwargs):
             form = urlparse.parse_qs(query_string)
             if not DATA in form:
                 raise ResponseError()
             params = {'message': form[DATA][0]}
             result = self.execute('response', params)
             d = dict(zip(RESPONSE_PARAMS, result))

     from gettext import gettext as _
     import warnings
     from common import PaymentCommon, FORM, Form, PaymentResponse, PAID, ERROR, CANCELED
     from common import (PaymentCommon, FORM, Form, PaymentResponse, PAID, ERROR,
             CANCELED, ResponseError)
     __all__ = ['Payment']
-...
         def response(self, query_string, **kwargs):
             form = urlparse.parse_qs(query_string)
             if not set(form) >= set(['Data', 'Seal', 'InterfaceVersion']):
                 raise ResponseError()
             self.logger.debug('received query string %r', form)
             assert 'Data' in form
             assert 'Seal' in form
             assert 'InterfaceVersion' in form
             data = self.decode_data(form['Data'][0])
             seal = form['Seal'][0]
             self.logger.debug('parsed response %r seal %r', data, seal)

     import Crypto.Cipher.DES
     from common import (PaymentCommon, URL, PaymentResponse, RECEIVED, ACCEPTED,
             PAID, ERROR)
             PAID, ERROR, ResponseError)
     def N_(message): return message
-...
         def response(self, query_string, logger=LOGGER, **kwargs):
             form = urlparse.parse_qs(query_string)
             if not set(form) >= set([REFERENCE, ETAT, REFSFP]):
                 raise ResponseError()
             for key, value in form.iteritems():
                 form[key] = value[0]
             logger.debug('received query_string %s' % query_string)

     import warnings
     from gettext import gettext as _
     from common import PaymentCommon, PaymentResponse, PAID, ERROR, FORM, Form
     from common import (PaymentCommon, PaymentResponse, PAID, ERROR, FORM, Form,
                         ResponseError)
     from cb import CB_RESPONSE_CODES
     __all__ = ['Payment']
-...
         def response(self, query_string, **kwargs):
             fields = urlparse.parse_qs(query_string, True)
             if not set(fields) >= set([SIGNATURE, VADS_CTX_MODE, VADS_AUTH_RESULT]):
                 raise ResponseError()
             for key, value in fields.iteritems():
                 fields[key] = value[0]
             copy = fields.copy()

     from decimal import Decimal, ROUND_DOWN
     from common import (PaymentCommon, PaymentResponse, URL, PAID, DENIED,
             CANCELLED, ERROR)
             CANCELLED, ERROR, ResponseError)
     from urllib import urlencode
     from urlparse import parse_qs
     from gettext import gettext as _
-...
         def response(self, query_string, **kwargs):
             fields = parse_qs(query_string, True)
             if not set(fields) >= set(['refdet', 'resultrans']):
                 raise ResponseError()
             for key, value in fields.iteritems():
                 fields[key] = value[0]
             refdet = fields.get('refdet')

     import eopayment
     import eopayment.ogone as ogone
     from eopayment import ResponseError
     PSPID = '2352566'
-...
                     'payid': '32100123', 'status': 9, 'ncerror': 0}
             response = ogone_backend.response(urllib.urlencode(data))
             self.assertEqual(response.order_id, order_id)
         def test_bad_response(self):
             ogone_backend = eopayment.Payment('ogone', BACKEND_PARAMS)
             order_id = 'myorder'
             data = {'payid': '32100123', 'status': 9, 'ncerror': 0}
             with self.assertRaises(ResponseError):
                 response = ogone_backend.response(urllib.urlencode(data))
+    -

Projet

Général

Profil

Produits Entr'ouvert » EOPayment

0001-general-check-responses-for-required-attributes-as-1.patch