Projet

Général

Profil

0002-trivial-remove-leftover-logging-code-from-old-prefil.patch

Frédéric Péters, 22 mai 2018 09:08

Télécharger (4,29 ko)

Voir les différences:

Subject: [PATCH 2/3] trivial: remove leftover logging code from old prefill
 mode (#23975)

 wcs/backoffice/submission.py |  4 ++--
 wcs/forms/root.py            | 17 +++++++----------
 2 files changed, 9 insertions(+), 12 deletions(-)
wcs/backoffice/submission.py
157 157
            form.add_hidden('submission_channel', self.selected_submission_channel)
158 158
        return form
159 159

  
160
    def form_side(self, step_no, page_no, log_detail=None, data=None, magictoken=None):
160
    def form_side(self, step_no, page_no, data=None, magictoken=None):
161 161
        r = TemplateIO(html=True)
162 162
        get_response().filter['sidebar'] = self.get_sidebar(data)
163 163
        r += htmltext('<div id="appbar">')
......
168 168
                r += htmltext('<a rel="popup" href="remove/%s">%s</a>') % (draft_formdata_id, _('Delete this form'))
169 169
        r += htmltext('</div>')
170 170
        r += htmltext('<div id="side">')
171
        r += self.step(step_no, page_no, log_detail, data=data)
171
        r += self.step(step_no, page_no, data=data)
172 172
        r += htmltext('</div> <!-- #side -->')
173 173
        return mark_safe(str(r.getvalue()))
174 174

  
wcs/forms/root.py
231 231
                return True
232 232
        return False
233 233

  
234
    def step(self, step_no, page_no, log_detail=None, data=None):
234
    def step(self, step_no, page_no, data=None):
235 235
        if step_no == 0:
236 236
            self.substvars['current_page_no'] = str(page_no + 1)
237
        if log_detail:
238
            get_logger().info('form %s - step %s (%s)' % (self.formdef.name, step_no, log_detail))
239
        else:
240
            get_logger().info('form %s - step %s' % (self.formdef.name, step_no))
237
        get_logger().info('form %s - step %s' % (self.formdef.name, step_no))
241 238

  
242 239
        page_labels = []
243 240
        current_position = 1
......
285 282
        r += htmltext('</ol></div>')
286 283
        return r.getvalue()
287 284

  
288
    def page(self, page_no, page_change=True, log_detail=None, page_error_messages=None):
285
    def page(self, page_no, page_change=True, page_error_messages=None):
289 286
        displayed_fields = []
290 287

  
291 288
        session = get_session()
......
410 407
        context = {
411 408
            'view': self,
412 409
            'form': form,
413
            'form_side': self.form_side(0, page_no, log_detail=log_detail, data=data, magictoken=magictoken)
410
            'form_side': self.form_side(0, page_no, data=data, magictoken=magictoken)
414 411
        }
415 412

  
416 413
        return template.render(
417 414
                list(self.get_formdef_template_variants(self.filling_templates)),
418 415
                context)
419 416

  
420
    def form_side(self, step_no, page_no, log_detail=None, data=None, magictoken=None):
417
    def form_side(self, step_no, page_no, data=None, magictoken=None):
421 418
        '''Create the elements that typically appear aside the main form
422 419
           (tracking code and steps).'''
423 420
        r = TemplateIO(html=True)
......
427 424
            # data (e.g. the user is not on a insufficient authenticiation
428 425
            # context page)
429 426
            r += self.tracking_code_box(data, magictoken)
430
        r += self.step(step_no, page_no, log_detail, data=data)
427
        r += self.step(step_no, page_no, data=data)
431 428
        r += htmltext('</div> <!-- #side -->')
432 429
        return mark_safe(str(r.getvalue()))
433 430

  
......
509 506
                    root_url, _('Login with %s') % auth_contexts[auth_context])
510 507
        return r.getvalue()
511 508

  
512
    def _q_index(self, log_detail=None):
509
    def _q_index(self):
513 510
        self.check_role()
514 511
        authentication_context_check_result = self.check_authentication_context()
515 512
        if authentication_context_check_result:
516
-