Projet

Général

Profil

0004-sms-ignore-empty-sms-addresses-submited-by-admin-pag.patch

Nicolas Roche, 27 août 2019 16:57

Télécharger (1,81 ko)

Voir les différences: 

Subject: [PATCH 4/4] sms: ignore empty sms addresses submited by admin page
 (#31823)


 tests/test_admin_pages.py | 9 +++++++++
 wcs/workflows.py          | 2 ++
 2 files changed, 11 insertions(+)
tests/test_admin_pages.py
2622 2622 

  		




  2623
  2623
  
    
    resp = resp.click('SMS')

  		




  2624
  2624
  
    
    resp = resp.form.submit()

  		




  
  2625
  
    
    assert 'to$element0$value_text' in resp.form.fields.keys()

  		




  
  2626
  
    
    assert 'to$element1$value_text' not in resp.form.fields.keys()

  		




  
  2627
  
    

  		




  
  2628
  
    
    resp = resp.form.submit('submit')

  		




  
  2629
  
    
    resp = resp.follow()

  		




  
  2630
  
    
    resp = resp.follow()

  		




  
  2631
  
    
    resp = resp.click(href='items/1/', index=0)

  		




  
  2632
  
    
    assert 'to$element0$value_text' in resp.form.fields.keys()

  		




  
  2633
  
    
    assert 'to$element1$value_text' not in resp.form.fields.keys()

  		




  2625
  2634
  
    

  		




  2626
  2635
  
    
def test_workflows_edit_display_form_action(pub):

  		




  2627
  2636
  
    
    create_superuser(pub)

  		












  

    
      wcs/workflows.py
    
  





  2620
  2620
  
    
        super(SendSMSWorkflowStatusItem, self).add_parameters_widgets(

  		




  2621
  2621
  
    
                form, parameters, prefix=prefix, formdef=formdef)

  		




  2622
  2622
  
    
        if 'to' in parameters:

  		




  
  2623
  
    
            # ignore empty text elements (as ComputedExpressionWidget does not)

  		




  
  2624
  
    
            self.to = [x for x in self.to if x]

  		




  2623
  2625
  
    
            form.add(WidgetList, '%sto' % prefix, title=_('To'),

  		




  2624
  2626
  
    
                     element_type=ComputedExpressionWidget,

  		




  2625
  2627
  
    
                     value=self.to, add_element_label=_('Add Number'),

  		




  2626
  
  
    
-