Projet

Général

Profil

0001-misc-log-traceback-for-cron-job-exceptions-44236.patch

Benjamin Dauvergne, 19 juin 2020 14:33

Télécharger (1,72 ko)

Voir les différences: 

Subject: [PATCH] misc: log traceback for cron job exceptions (#44236)


 passerelle/base/management/commands/cron.py | 3 ++-
 tests/test_cron.py                          | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
passerelle/base/management/commands/cron.py
48 48 
                try:
49 49 
                    getattr(connector, frequency)()
50 50 
                except Exception as e:
51 
                    connector.logger.error('error running %s job (%r)' % (frequency, e))
51 
                    connector.logger.exception('connector "%s.%s" error running %s job' % (
52 
                        connector.get_connector_slug(), connector.slug, frequency))
52 53 
                    errors.append({'connector': connector, 'exception': e, 'traceback': traceback.format_exc()})
53 54 
        if errors:
54 55 
            for error in errors:
tests/test_cron.py
20 20 
            new=mock.Mock(side_effect=excep)):
21 21 
        with pytest.raises(CommandError):
22 22 
            call_command('cron', 'hourly')
23 
        assert caplog.records[0].message == "error running hourly job (%s)" % repr(excep)
23 
        assert caplog.records[0].message == 'connector "base-adresse.base-adresse" error running hourly job'
24 
-