Projet

Général

Profil

0001-dummy-remove-unused-siret-parameter-34064.patch

Benjamin Dauvergne, 26 octobre 2020 20:42

Télécharger (3,19 ko)

Voir les différences: 

Subject: [PATCH] dummy: remove unused siret parameter (#34064)


 eopayment/dummy.py  | 12 +-----------
 tests/test_dummy.py |  5 ++---
 2 files changed, 3 insertions(+), 14 deletions(-)
eopayment/dummy.py
88 88 
                'type': str,
89 89 
                'default': 'origin',
90 90 
            },
91 
            {
92 
                'name': 'siret',
93 
                'caption': 'dummy siret parameter',
94 
                'validation': lambda x: x.isdigit(),
95 
                'validation_err_msg': 'must be a number',
96 
                'type': str,
97 
                'default': '1234',
98 
                'required': True,
99 
            },
100 91 
            {
101 92 
                'name': 'consider_all_response_signed',
102 93 
                'caption': (
......
149 140 
            '%s amount %s name %s address %s email %s phone %s'
150 141 
            ' next_url %s info1 %s info2 %s info3 %s kwargs: %s',
151 142 
            __name__, amount, name, address, email, phone, info1, info2, info3, next_url, kwargs)
152 
        transaction_id = self.transaction_id(30, ALPHANUM, 'dummy', self.siret)
143 
        transaction_id = self.transaction_id(30, ALPHANUM, 'dummy')
153 144 
        normal_return_url = self.normal_return_url
154 145 
        if next_url and not normal_return_url:
155 146 
            warnings.warn("passing next_url to request() is deprecated, "
......
162 153 
            automatic_return_url = self.direct_notification_url
163 154 
        query = {
164 155 
            'transaction_id': transaction_id,
165 
            'siret': self.siret,
166 156 
            'amount': amount,
167 157 
            'email': email,
168 158 
            'return_url': normal_return_url or '',
tests/test_dummy.py
25 25 
def backend():
26 26 
    options = {
27 27 
        'automatic_notification_url': 'http://example.com/direct_notification_url',
28 
        'siret': '1234',
29 28 
        'origin': 'Mairie de Perpette-les-oies'
30 29 
    }
31 30 
    return eopayment.Payment('dummy', options)
......
33 32 

  		




  34
  33
  
    
def test_request(backend, freezer):

  		




  35
  34
  
    
    freezer.move_to('2020-01-01 00:00:00+01:00')

  		




  36
  
  
    
    transaction_id, method, raw_url = backend.request('10.10', capture_date=datetime.date(2020, 1, 7), subject='Repas pour 4 personnes')

  		




  
  35
  
    
    transaction_id, method, raw_url = backend.request(

  		




  
  36
  
    
        '10.10', capture_date=datetime.date(2020, 1, 7), subject='Repas pour 4 personnes')

  		




  37
  37
  
    
    assert transaction_id

  		




  38
  38
  
    
    assert method == 1

  		




  39
  39
  
    
    url = urlparse(raw_url)

  		




  ......




  43
  43
  
    
    assert url.fragment == ''

  		




  44
  44
  
    
    qs = {k: v[0] for k, v in parse_qs(url.query).items()}

  		




  45
  45
  
    
    assert qs['transaction_id'] == transaction_id

  		




  46
  
  
    
    assert qs['siret'] == '1234'

  		




  47
  46
  
    
    assert qs['amount'] == '10.10'

  		




  48
  47
  
    
    assert qs['origin'] == 'Mairie de Perpette-les-oies'

  		




  49
  48
  
    
    assert qs['capture_day'] == '6'

  		




  50
  
  
    
-