0016-misc-pylint-fix-global-statement-global-variable-not.patch

Lauréline Guérin, 02 avril 2021 17:21

Voir les différences: en ligne côte à côte

Subject: [PATCH 16/18] misc: pylint fix global-statement,
 global-variable-not-assigned (#52630)

 tests/test_formdata.py | 51 ++++++++++++++++++++++--------------------
 tests/test_sql.py      |  1 -
 2 files changed, 27 insertions(+), 25 deletions(-)

     from quixote import get_publisher
     from quixote.http_request import Upload
     from wcs import fields, formdef, sessions
     from wcs import fields, sessions
     from wcs.blocks import BlockDef
     from wcs.carddef import CardDef
     from wcs.categories import Category
-...
         pub.cfg['language'] = {'language': 'en'}
         pub.write_cfg()
         FormDef.wipe()
         Category.wipe()
         return pub
         cat = Category(name='test category')
         cat.store()
         global formdef
     @pytest.fixture
     def formdef(pub):
         FormDef.wipe()
         formdef = FormDef()
         formdef.name = 'foobar'
         formdef.url_name = 'foobar'
         formdef.fields = []
         formdef.category_id = cat.id
         formdef.store()
         return pub
         return formdef
     def teardown_module(module):
-...
         return user
     def test_basic(pub):
     def test_basic(pub, formdef):
         Category.wipe()
         cat = Category(name='test category')
         cat.store()
         formdef.category_id = cat.id
         formdef.store()
         formdata = formdef.data_class()()
         substvars = formdata.get_substitution_variables()
         assert substvars.get('form_status') == 'Unknown'
-...
         assert substvars.get('category_name') == 'test category'
     def test_saved(pub):
     def test_saved(pub, formdef):
         formdef.data_class().wipe()
         formdata = formdef.data_class()()
         formdata.store()
-...
         assert substvars.get('form_status_url').endswith('/foobar/1/status')
     def test_auto_display_id(pub):
     def test_auto_display_id(pub, formdef):
         formdef.data_class().wipe()
         formdata = formdef.data_class()()
         formdata.store()
-...
         assert substvars.get('form_number_raw') == str(formdata.id)
     def test_manual_display_id(pub):
     def test_manual_display_id(pub, formdef):
         formdef.data_class().wipe()
         formdata = formdef.data_class()()
         formdata.id_display = 'bar'
-...
         assert substvars.get('form_number_raw') == str(formdata.id)
     def test_submission_context(pub, local_user):
     def test_submission_context(pub, formdef, local_user):
         formdef.data_class().wipe()
         formdata = formdef.data_class()()
         formdata.backoffice_submission = True
-...
         assert substvars.get('form_submission_agent_email') is None
     def test_just_created(pub):
     def test_just_created(pub, formdef):
         formdef.data_class().wipe()
         formdata = formdef.data_class()()
         formdata.just_created()
-...
         assert substvars.get('form_evolution')
     def test_field(pub):
     def test_field(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [fields.StringField(id='0', label='string')]
         formdef.store()
-...
         assert substvars.get('form_field_string') == 'test'
     def test_field_varname(pub):
     def test_field_varname(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [fields.StringField(id='0', label='string', varname='foo')]
         formdef.store()
-...
         assert substvars.get('form_var_foo') == 'test'
     def test_file_field(pub):
     def test_file_field(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [fields.FileField(id='0', label='file', varname='foo')]
         formdef.store()
-...
         assert substvars['form_var_foo_url'] is None
     def test_get_submitter(pub):
     def test_get_submitter(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [
             fields.StringField(id='0', label='email', varname='foo', prefill={'type': 'user', 'value': 'email'})
-...
         assert formdef.get_submitter_email(formdata) == 'bar@localhost'
     def test_get_last_update_time(pub):
     def test_get_last_update_time(pub, formdef):
         formdef.data_class().wipe()
         formdef.store()
         formdata = formdef.data_class()()
         assert formdata.last_update_time is None
-...
         assert formdata.last_update_time == formdata.receipt_time
     def test_password_field(pub):
     def test_password_field(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [fields.PasswordField(id='0', label='pwd')]
         formdef.store()
-...
         assert formdata2.data == {'0': {'cleartext': 'foo'}}
     def test_date_field(pub):
     def test_date_field(pub, formdef):
         formdef.data_class().wipe()
         formdef.fields = [fields.DateField(id='0', label='date')]
         formdef.store()
-...
         assert variables.get('form_var_xxx_raw') is True
     def test_backoffice_field_varname(pub):
     def test_backoffice_field_varname(pub, formdef):
         wf = Workflow(name='bo fields')
         wf.backoffice_fields_formdef = WorkflowBackofficeFieldsFormDef(wf)
         wf.backoffice_fields_formdef.fields = [
-...
         assert substvars.get('form_var_backoffice_blah') == 'test'
     def test_workflow_data_file_url(pub):
     def test_workflow_data_file_url(pub, formdef):
         upload = PicklableUpload('test.txt', 'text/plain', 'ascii')
         upload.receive([b'first line', b'second line'])

     @postgresql
     def test_urlname_change():
         global formef
         data_class = formdef.data_class(mode='sql')
         data_class.wipe()
         assert formdef.url_name == 'tests'
+    -

Projet

Général

Profil

Produits Entr'ouvert » w.c.s.

0016-misc-pylint-fix-global-statement-global-variable-not.patch