Projet

Général

Profil

0005-portfolio-don-t-log-successful-pushes-61292.patch

Frédéric Péters, 01 février 2022 16:28

Télécharger (2,1 ko)

Voir les différences:

Subject: [PATCH 5/8] portfolio: don't log successful pushes (#61292)

 tests/form_pages/test_formdata.py | 2 --
 wcs/portfolio.py                  | 6 ++----
 2 files changed, 2 insertions(+), 6 deletions(-)
tests/form_pages/test_formdata.py
1 1
import base64
2 2
import io
3 3
import json
4
import locale
5 4
import os
6 5
import urllib.parse
7 6
import xml.etree.ElementTree as ET
......
850 849
        assert payload['user_email'] == 'foo@localhost'
851 850
        assert payload['origin'] == 'example.net'
852 851
        assert base64.decodebytes(force_bytes(payload['file_b64_content'])).startswith(b'%PDF')
853
        assert caplog.records[-1].message.startswith("file 'template.pdf' pushed to portfolio of 'Foo")
854 852
    assert resp.location == form_location + '#action-zone'
855 853
    resp = resp.follow()  # back to form page
856 854

  
wcs/portfolio.py
25 25

  
26 26
from wcs.api_utils import get_secret_and_orig, sign_url
27 27

  
28
from .qommon import _, get_logger
28
from .qommon import _
29 29
from .qommon.misc import http_post_request, json_loads, urlopen
30 30

  
31 31

  
......
78 78
    def afterjob(job):
79 79
        status = 0
80 80
        status = async_post()[0]
81
        if status == 200:
82
            get_logger().info('file %r pushed to portfolio of %r', filename, user.display_name)
83
        else:
81
        if status != 200:
84 82
            publisher.record_error(
85 83
                _('file %(filename)r failed to be pushed to portfolio of %(display_name)r')
86 84
                % {'filename': filename, 'display_name': user.display_name}
87
-