0001-idp_oidc-profile-selection-error-when-prompt-none-72.patch

Paul Marillonnet, 16 décembre 2022 11:01

Voir les différences: en ligne côte à côte

Subject: [PATCH] idp_oidc: profile selection error when prompt=none (#72507)

 src/authentic2_idp_oidc/views.py |  9 +++++++
 tests/idp_oidc/test_misc.py      | 45 ++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)

         show_message = False
     class SelectAccountRequired(OIDCException):
         error_code = 'select_account_required'
         show_message = False
     class AccessDenied(OIDCException):
         error_code = 'access_denied'
         show_message = False
-...
                 needs_scope_validation = True
             if needs_scope_validation or (user_has_selectable_profiles and client.activate_user_profiles):
                 if 'none' in prompt:
                     if user_has_selectable_profiles and client.activate_user_profiles:
                         raise SelectAccountRequired(
                             _('User profile selection is required but prompt parameter is "none"')
+                        )
                     raise ConsentRequired(_('Consent is required but prompt parameter is "none"'))
                 if request.method == 'POST':
                     if request.POST.get('profile-validation', ''):

     from authentic2.a2_rbac.models import OrganizationalUnit, Role
     from authentic2.a2_rbac.utils import get_default_ou
     from authentic2.custom_user.models import Profile, ProfileType
     from authentic2.models import Attribute, AuthorizedRole
     from authentic2.utils.misc import good_next_url, make_url
     from authentic2_auth_oidc.utils import parse_timestamp
-...
                 response, 'consent_required', 'Consent is required but prompt parameter is "none"', message=False
+            )
             # prompt is none, but account selection is required
             oidc_client.activate_user_profiles = True
             oidc_client.save()
             profile_type_manager = ProfileType.objects.create(
                 name='One Manager Type',
                 slug='one-manager-type',
+            )
             profile_type_delegate = ProfileType.objects.create(
                 name='One Delegate Type',
                 slug='one-delegate-type',
+            )
             profile_manager = Profile.objects.create(
                 user=simple_user,
                 profile_type=profile_type_manager,
                 identifier='Entity 789',
                 email='manager@example789.org',
+            )
             profile_delegate = Profile.objects.create(
                 user=simple_user,
                 profile_type=profile_type_delegate,
                 identifier='Entity 1011',
                 email='delegate@example1011.org',
+            )
             response = app.get(
                 make_url(
                     'oidc-authorize',
                     params={
                         'client_id': oidc_client.client_id,
                         'redirect_uri': redirect_uri,
                         'response_type': response_type,
                         'scope': 'openid',
                         'prompt': 'none',
                     },
+                )
+            )
             assert_authorize_error(
                 response,
                 'select_account_required',
                 'User profile selection is required but prompt parameter is "none"',
                 message=False,
+            )
             profile_manager.delete()
             profile_delegate.delete()
             # user do not consent
             response = app.get(
                 make_url(
+    -

Projet

Général

Profil

Produits Entr'ouvert » Authentic 2

0001-idp_oidc-profile-selection-error-when-prompt-none-72.patch