0001-misc-don-t-display-wrong-answer-on-initial-display-o.patch

Frédéric Péters, 07 décembre 2015 09:26

Voir les différences: en ligne côte à côte

Subject: [PATCH] misc: don't display wrong answer on initial display of
 captcha (#9222)

When tracking codes are enabled request.form is filled with magictoken and thus
the captcha form is considered to be submitted, and obviously wrong.

 tests/test_form_pages.py | 27 +++++++++++++++++++++++++++
 wcs/qommon/form.py       |  4 ++--
 2 files changed, 29 insertions(+), 2 deletions(-)

         resp = resp.click('test')
         assert 'Some field' in resp.body
     def test_form_captcha_and_tracking_code(pub):
         user = create_user(pub)
         formdef = create_formdef()
         formdef.data_class().wipe()
         formdef.fields = [fields.StringField(id='0', label='Some field')]
         formdef.has_captcha = True
         formdef.enable_tracking_codes = True
         formdef.store()
         # check the captcha is not given as being an error
         app = get_app(pub)
         resp = app.get('/')
         resp = resp.click('test')
         assert 'form_captcha' in resp.body
         assert not 'wrong answer' in resp.body
         resp.form['captcha$q'] = 'az' # wrong answer
         resp = resp.form.submit()
         assert 'form_captcha' in resp.body
         assert 'wrong answer' in resp.body
         session_id = app.cookies.values()[0].strip('"')
         session = BasicSession.get(session_id)
         resp.form['captcha$q'] = session.get_captcha_token(resp.forms[0]['captcha$token'].value)['answer']
         resp = resp.form.submit()
         assert 'f0' in resp.form.fields
     def test_form_file_field_submit(pub):
         formdef = create_formdef()
         formdef.fields = [fields.FileField(id='0', label='file')]

                 self.hint = kwargs.get('hint')
                 if self.hint is None:
                     self.hint = _('Please answer this simple mathematical question as proof you are not a bot.')
             self.add(StringWidget, 'q', required=True)
             self.add(StringWidget, 'q', required=True, attrs={'required': 'required'})
             token['answer'] = str(answer)
         def _parse(self, request):
-...
             if v['answer'] and token and token['answer'] == v['answer'].strip():
                 get_session().won_captcha = True
                 self.value = v
             else:
             elif v['answer']:
                 self.error = _('wrong answer')
         def get_title(self):
+    -

Projet

Général

Profil

Produits Entr'ouvert » w.c.s.

0001-misc-don-t-display-wrong-answer-on-initial-display-o.patch