Produits Entr'ouvert » Combo

Voilà le patch, mais ça fait planter des tests dont je ne comprends même pas le code dans tests/test_lingo_payment.py

tests/test_lingo_payment.py::test_successfull_items_payment FAILED
tests/test_lingo_payment.py::test_payment_callback FAILED

Sur cette erreur :

============================================================ FAILURES ============================================================
_________________________________________________ test_successfull_items_payment _________________________________________________

regie = <Regie: Test>, user = <User: admin>

    def test_successfull_items_payment(regie, user):
        items = {'item1': {'amount': '10.5', 'source_url': '/item/1'},
                 'item2': {'amount': '42', 'source_url': '/item/2'},
                 'item3': {'amount': '100', 'source_url': '/item/3'},
                 'item4': {'amount': '354', 'source_url': '/item/4'}
        }
        b_items = []
        for subject, details in items.iteritems():
            b_item = BasketItem.objects.create(user=user, regie=regie,
                                        subject=subject, **details)
            b_items.append(b_item.pk)
        login()
        resp = client.post(reverse('lingo-pay'), {'item': b_items, 'regie': regie.pk})
        assert resp.status_code == 302
        location = resp.get('location')
        assert 'dummy-payment' in location
        parsed = urlparse.urlparse(location)
        # get return_url and transaction id from location
        qs = urlparse.parse_qs(parsed.query)
        args = {'transaction_id': qs['transaction_id'][0], 'signed': True,
                'ok': True, 'reason': 'Paid'}
        # make sure return url is the user return URL
        assert urlparse.urlparse(qs['return_url'][0]).path.startswith(
                reverse('lingo-return', kwargs={'regie_pk': regie.id}))
        # simulate successful return URL
        resp = client.get(qs['return_url'][0], args)
        assert resp.status_code == 302
        assert urlparse.urlparse(resp.url).path == '/'
        # simulate successful call to callback URL
>       resp = client.get(reverse('lingo-callback', kwargs={'regie_pk': regie.id}), args)

tests/test_lingo_payment.py:129: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../publik/venv/local/lib/python2.7/site-packages/django/test/client.py:500: in get
    **extra)
../publik/venv/local/lib/python2.7/site-packages/django/test/client.py:303: in get
    return self.generic('GET', path, secure=secure, **r)
../publik/venv/local/lib/python2.7/site-packages/django/test/client.py:379: in generic
    return self.request(**r)
../publik/venv/local/lib/python2.7/site-packages/django/test/client.py:466: in request
    six.reraise(*exc_info)
../publik/venv/local/lib/python2.7/site-packages/django/core/handlers/base.py:132: in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
../publik/venv/local/lib/python2.7/site-packages/django/views/generic/base.py:71: in view
    return self.dispatch(request, *args, **kwargs)
../publik/venv/local/lib/python2.7/site-packages/django/views/decorators/csrf.py:58: in wrapped_view
    return view_func(*args, **kwargs)
combo/apps/lingo/views.py:450: in dispatch
    return super(CallbackView, self).dispatch(*args, **kwargs)
../publik/venv/local/lib/python2.7/site-packages/django/views/generic/base.py:89: in dispatch
    return handler(request, *args, **kwargs)
combo/apps/lingo/views.py:443: in get
    return self.handle_callback(request, request.environ['QUERY_STRING'], **kwargs)
combo/apps/lingo/views.py:432: in handle_callback
    item.notify_payment()
combo/apps/lingo/models.py:192: in notify_payment
    self.notify('paid')
combo/apps/lingo/models.py:188: in notify
    data=json.dumps(message), headers=headers, timeout=3)
../publik/venv/local/lib/python2.7/site-packages/requests/sessions.py:522: in post
    return self.request('POST', url, data=data, json=json, **kwargs)
combo/utils.py:162: in request
    response = super(Requests, self).request(method, url, **kwargs)
../publik/venv/local/lib/python2.7/site-packages/requests/sessions.py:461: in request
    prep = self.prepare_request(req)
../publik/venv/local/lib/python2.7/site-packages/requests/sessions.py:394: in prepare_request
    hooks=merge_hooks(request.hooks, self.hooks),
../publik/venv/local/lib/python2.7/site-packages/requests/models.py:294: in prepare
    self.prepare_url(url, params)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <PreparedRequest [POST]>, url = '/item/2jump/trigger/paid', params = OrderedDict()

    def prepare_url(self, url, params):
        """Prepares the given HTTP URL.""" 
        #: Accept objects that have string representations.
        #: We're unable to blindly call unicode/str functions
        #: as this will include the bytestring indicator (b'')
        #: on python 3.x.
        #: https://github.com/kennethreitz/requests/pull/2238
        if isinstance(url, bytes):
            url = url.decode('utf8')
        else:
            url = unicode(url) if is_py2 else str(url)

        # Don't do any URL preparation for non-HTTP schemes like `mailto`,
        # `data` etc to work around exceptions from `url_parse`, which
        # handles RFC 3986 only.
        if ':' in url and not url.lower().startswith('http'):
            self.url = url
            return

        # Support for unicode domain names and paths.
        try:
            scheme, auth, host, port, path, query, fragment = parse_url(url)
        except LocationParseError as e:
            raise InvalidURL(*e.args)

        if not scheme:
            error = ("Invalid URL {0!r}: No schema supplied. Perhaps you meant http://{0}?")
            error = error.format(to_native_string(url, 'utf8'))

>           raise MissingSchema(error)
E           MissingSchema: Invalid URL '/item/2jump/trigger/paid': No schema supplied. Perhaps you meant http:///item/2jump/trigger/paid?

../publik/venv/local/lib/python2.7/site-packages/requests/models.py:354: MissingSchema
------------------------------------------------------ Captured stderr call ------------------------------------------------------
No handlers could be found for logger "combo.apps.lingo.views" 
WARNING:root:service not found in settings.KNOWN_SERVICES for /item/2jump/trigger/paid

Et bon, en fait, je ne comprends pas les « 'source_url': '/item/1' »

Oui mais alors ce que je ne comprends pas : dans le code actuel, quand "aucun service n'est trouvé qui corresponde" notify devrait crasher (raise RuntimeError('failed to find data for server')), non ?

Patch où les tests sont ok ; j'ai préféré adapter les tests pour les rendre plus réalistes (et au passage je regarde vite si le callback lancera bien un notify).

Voilà le patch «get name id from user object», avec des s/item/invoice/ là où j'ai trouvé que ça avait du sens. Il reste des "item" dans le code parce qu'encore du mélange avec les BasketItems, et que je préfèrerai un patch séparé pour finir ce nettoyage.

commit 005d003292560289ff0e47c02a86656ea52b9d6a
Author: Thomas NOEL <tnoel@entrouvert.com>
Date:   Fri Oct 21 14:06:20 2016 +0200

    lingo: get name id from user object instead of session (#13124)

Erreur sur la dev:

NameError: global name 'boot' is not defined
(2 additional frame(s) were not displayed)
...
  File "combo/apps/lingo/models.py", line 454, in render
    return super(Items, self).render(context)
  File "combo/data/models.py", line 437, in render
    context.update(self.get_cell_extra_context(context))
  File "combo/apps/lingo/models.py", line 445, in get_cell_extra_context
    items = self.get_invoices(user=context['user'])
  File "combo/apps/lingo/models.py", line 479, in get_invoices
    items.extend(r.get_invoices(user))
  File "combo/apps/lingo/models.py", line 125, in get_invoices
    return self.basketitem_set.filter(payment_date__isnull=boot(not history), user=user)

#13757.