Bug #20796
crash sur un appel non authentifié à l'annulation d'un élément du panier
Début:
19 décembre 2017
Echéance:
% réalisé:
0%
Temps estimé:
Patch proposed:
Oui
Planning:
Description
... File "/usr/lib/python2.7/dist-packages/django/views/generic/detail.py", line 32, in get_object queryset = self.get_queryset() File "/usr/lib/python2.7/dist-packages/combo/apps/lingo/views.py", line 580, in get_queryset return BasketItem.get_items_to_be_paid(user=self.request.user) File "/usr/lib/python2.7/dist-packages/combo/apps/lingo/models.py", line 231, in get_items_to_be_paid cancellation_date__isnull=True) File "/usr/lib/python2.7/dist-packages/django/db/models/manager.py", line 127, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/django/db/models/query.py", line 679, in filter return self._filter_or_exclude(False, *args, **kwargs) File "/usr/lib/python2.7/dist-packages/django/db/models/query.py", line 697, in _filter_or_exclude clone.query.add_q(Q(*args, **kwargs)) File "/usr/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1310, in add_q clause, require_inner = self._add_q(where_part, self.used_aliases) File "/usr/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1338, in _add_q allow_joins=allow_joins, split_subq=split_subq, File "/usr/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1200, in build_filter lookups, value) File "/usr/lib/python2.7/dist-packages/django/db/models/fields/related.py", line 1758, in get_lookup_constraint lookup_class(target.get_col(alias, source), val), AND) File "/usr/lib/python2.7/dist-packages/django/db/models/lookups.py", line 105, in __init__ self.rhs = self.get_prep_lookup() File "/usr/lib/python2.7/dist-packages/django/db/models/lookups.py", line 143, in get_prep_lookup return self.lhs.output_field.get_prep_lookup(self.lookup_name, self.rhs) File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 727, in get_prep_lookup return self.get_prep_value(value) File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 985, in get_prep_value return int(value) TypeError: int() argument must be a string or a number, not 'SimpleLazyObject'
Fichiers
Révisions associées
Historique
Mis à jour par Frédéric Péters il y a plus de 6 ans
- Fichier 0001-lingo-don-t-crash-on-anonymous-access-to-cancel-view.patch 0001-lingo-don-t-crash-on-anonymous-access-to-cancel-view.patch ajouté
- Statut changé de Nouveau à En cours
- Patch proposed changé de Non à Oui
Minimaliste, c'est géré ensuite derrière dans la méthode post() :
if not request.user.is_authenticated(): messages.error(request, _('An error occured when removing the item. ' '(no authenticated user)'))
Mis à jour par Frédéric Péters il y a plus de 6 ans
- Statut changé de En cours à Résolu (à déployer)
commit dccca6effccb08bbd0822e77eb911ae82ae132ed Author: Frédéric Péters <fpeters@entrouvert.com> Date: Tue Dec 19 11:01:05 2017 +0100 lingo: don't crash on anonymous access to cancel view (#20796)
Mis à jour par Frédéric Péters il y a plus de 5 ans
- Statut changé de Résolu (à déployer) à Solution déployée
lingo: don't crash on anonymous access to cancel view (#20796)