Project

General

Profile

Bug #38206

Nav background au dessus du header en mobile

Added by Thomas Jund 8 months ago. Updated 8 months ago.

Status:
Solution déployée
Priority:
Normal
Assignee:
Target version:
-
Start date:
04 Dec 2019
Due date:
% Done:

0%

Patch proposed:
Yes
Planning:
No

Description

SI

  • $nav-background a une valeur,
  • $nav-full-width-background == true

Alors en mode hamburger, la nav conserve son background et recouvre le background du header.

background-nav-audessus-header.png View (20.2 KB) Thomas Jund, 04 Dec 2019 04:33 PM

desktop.png View (18.3 KB) Thomas Jund, 04 Dec 2019 04:33 PM

0001-scss-nav-hambuger-mode-remove-background-even-it-s-f.patch View (955 Bytes) Thomas Jund, 04 Dec 2019 04:45 PM

0001-scss-nav-hambuger-mode-remove-background-even-it-s-f.patch View (945 Bytes) Thomas Jund, 04 Dec 2019 05:50 PM

39594
39595

Associated revisions

Revision a156f1bd (diff)
Added by Thomas Jund 8 months ago

scss: always clear navigation background in hamburger mode (#38206)

History

#1 Updated by Thomas Jund 8 months ago

Au passage, j'améliore un peu le reset du background

#2 Updated by Frédéric Péters 8 months ago

background: transparent dit réinitialiser toutes les propriétés, je ne capte pas la nécessité de none transparent.

#3 Updated by Thomas Jund 8 months ago

  • File 0001-scss-nav-hambuger-mode-remove-background-even-it-s-f.patch added

À rien en effet.

#4 Updated by Frédéric Péters 8 months ago

Le même patch a été remis.

#5 Updated by Thomas Jund 8 months ago

  • File deleted (0001-scss-nav-hambuger-mode-remove-background-even-it-s-f.patch)

#7 Updated by Frédéric Péters 8 months ago

  • Status changed from Solution proposée to Solution validée

Ok mais le message de commit est à relire/refaire, genre "scss: always clear navigation background in hamburger mode".

#8 Updated by Thomas Jund 8 months ago

  • Status changed from Solution validée to Solution déployée
commit a156f1bd47599548a7053142bfc3866aa53623a5 (HEAD -> master, origin/master, origin/HEAD)
Author: Thomas JUND <tjund@entrouvert.com>
Date:   Wed Dec 4 16:44:13 2019 +0100

    scss: always clear navigation background in hamburger mode (#38206)

Also available in: Atom PDF