Project

General

Profile

Development #30543

auth_saml: prendre en compte le paramètre request dans "authenticate"

Added by Serghei Mihai about 1 year ago. Updated about 1 year ago.

Status:
Solution déployée
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12 Feb 2019
Due date:
% Done:

0%

Patch proposed:
Yes
Planning:
No

Description

Suite à #30541.

0001-auth_saml-pass-request-param-to-authenticate-method-.patch View (1.09 KB) Serghei Mihai, 12 Feb 2019 10:02 AM

0001-auth_saml-remove-useless-credentials-param-30543.patch View (1.07 KB) Serghei Mihai, 12 Feb 2019 11:22 AM

0001-auth_saml-remove-useless-credentials-param-and-add-o.patch View (1.12 KB) Serghei Mihai, 12 Feb 2019 12:09 PM

0001-auth_saml-remove-useless-credentials-param-and-add-o.patch View (1.14 KB) Serghei Mihai, 13 Feb 2019 07:20 PM


Related issues

Related to django-mellon - Development #30541: django1.11: authenticate() got an unexpected keyword argument 'request' Solution déployée 12 Feb 2019

Associated revisions

Revision 506df5b5 (diff)
Added by Serghei Mihai about 1 year ago

auth_saml: remove useless credentials param and add optional request (#30543)

And so assure compliance with Django 1.11

History

#1 Updated by Serghei Mihai about 1 year ago

#2 Updated by Benjamin Dauvergne about 1 year ago

Tu peux virer credentials.

#3 Updated by Serghei Mihai about 1 year ago

Oui, parce que Django 1.11 fait un inspect des paramètres de la fonction authenticate et ne passe pas request s'il n'est pas attendu.

#4 Updated by Benjamin Dauvergne about 1 year ago

Tu peux ajouter request quand même.... le jour où django-mellon s'en servira on sera bien content de ne pas revenir sur auth-saml.

#6 Updated by Benjamin Dauvergne about 1 year ago

Serghei Mihai a écrit :

ok.

Dans l'appel à super(), (saml_attributes=saml_attributes, request=request).

#7 Updated by Serghei Mihai about 1 year ago

Oui.

#8 Updated by Serghei Mihai about 1 year ago

  • Related to Development #30541: django1.11: authenticate() got an unexpected keyword argument 'request' added

#9 Updated by Benjamin Dauvergne about 1 year ago

  • Status changed from Solution proposée to Solution validée

Ack.

#10 Updated by Serghei Mihai about 1 year ago

  • Status changed from Solution validée to Résolu (à déployer)
commit 506df5b5ce90303996184546fdbf51c86af7035c (origin/master, origin/HEAD)
Author: Serghei Mihai <smihai@entrouvert.com>
Date:   Tue Feb 12 10:00:31 2019 +0100

    auth_saml: remove useless credentials param and add optional request (#30543)

    And so assure compliance with Django 1.11

#11 Updated by Frédéric Péters about 1 year ago

  • Status changed from Résolu (à déployer) to Solution déployée

Also available in: Atom PDF