Project

General

Profile

Support #32425

Improve build compatibility across platforms

Added by Joao Costa 9 months ago. Updated 5 months ago.

Status:
Résolu (à déployer)
Priority:
Normal
Category:
Core
Target version:
Start date:
17 Apr 2019
Due date:
% Done:

0%

Patch proposed:
Yes
Planning:
No

Description

The patches attached to this issue are based on the patches available in the pkgsrc system ( https://github.com/NetBSD/pkgsrc/tree/pkgsrc-2019Q1/security/lasso/patches ). They improve the ability to build lasso on different platforms.

In the configure script, "test(1)" is called with a "==". From the test manpage(https://linux.die.net/man/1/test), the standard string comparison operator in test is "=" and not "==", and although "==" works with the most commonly used systems, "=" gives better compatibility.

On lasso/xml/tools.c, _XOPEN_SOURCE is defined. This fails on sun.

patch-lasso_xml_tools.c View - Set _XOPEN_SOURCE correctly. (405 Bytes) Joao Costa, 17 Apr 2019 03:57 PM

patch-configure - Use = instead of == for test(1) portability sake. (275 Bytes) Joao Costa, 17 Apr 2019 04:08 PM

Associated revisions

Revision 84bc5b48 (diff)
Added by Benjamin Dauvergne 5 months ago

Improve compatibility with Solaris (#32425)

Revision caecf46b (diff)
Added by Benjamin Dauvergne 5 months ago

Improve configure compatibility (#32425)

History

#1 Updated by Benjamin Dauvergne 5 months ago

  • Assignee set to Benjamin Dauvergne

#2 Updated by Benjamin Dauvergne 5 months ago

  • Target version set to 2.6.1

#3 Updated by Benjamin Dauvergne 5 months ago

  • Status changed from Nouveau to Résolu (à déployer)
commit caecf46be47f712893046a7c6ac1ac9cbbc11779
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Fri Sep 6 14:43:31 2019 +0200

    Improve configure compatibility (#32425)

commit 84bc5b48d3094cd6d69c562eb70e62dd7c81d796
Author: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date:   Fri Sep 6 14:42:44 2019 +0200

    Improve compatibility with Solaris (#32425)

Also available in: Atom PDF