Bug #7206: sekizai is impossible to deal with theming-wise - Authentic 2 - Redmine Entr’ouvert

Bug #7206

sekizai is impossible to deal with theming-wise

Added by Frédéric Péters about 10 years ago. Updated about 10 years ago.

Status:

Fermé

Priority:

Bas

Assignee:

Benjamin Dauvergne (retour le 1er août)

Category:

Target version:

2.1.20

Start date:

12 May 2015

Due date:

% Done:

100%

Estimated time:

Patch proposed:

Yes

Planning:

Description

The insistance of sekizai templatetags to be declared in the top template makes authentic theming quite a pain; e.g. you cannot do:

{% extends 'theme/common.html' %}
{% block extra-head %}
{% render_block "css" %}
{% render_block "js" %}
{% endblock %}

Files

0001-templates-replace-use-of-sekizai-by-our-own-template.patch (7.58 KB) 0001-templates-replace-use-of-sekizai-by-our-own-template.patch

Benjamin Dauvergne (retour le 1er août), 14 May 2015 10:53 PM

Associated revisions

Revision f145e127 (diff)
Added by Benjamin Dauvergne (retour le 1er août) about 10 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

Revision 66815866 (diff)
Added by Benjamin Dauvergne (retour le 1er août) about 10 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

Revision 4c1b2b0f (diff)
Added by Benjamin Dauvergne (retour le 1er août) about 10 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

History

Updated by Benjamin Dauvergne (retour le 1er août) about 10 years ago

Are you sure it does not work or are you quoting the documentation ? It seems to me that the way authentic uses sekizai it should work.

The principle of sekizai is to set a dictionary in a context variable before template rendering and during rendering the dictionnary is filled by subtemplates.

I think that this behaviour is broken if you put the render_block and addtoblock tag in different blocks of the same template as I think you cannot be sure of the ordering of the rendering. But that is not how authentic use sekizai, we begin by rendering subtemplates for the different authentication frontend class, the we pass the rendered blocks to the final template of the login view. Maybe in this case it still works.