Project

General

Profile

Bug #7206

sekizai is impossible to deal with theming-wise

Added by Frédéric Péters about 9 years ago. Updated about 9 years ago.

Status:
Fermé
Priority:
Bas
Category:
-
Target version:
Start date:
12 May 2015
Due date:
% Done:

100%

Estimated time:
Patch proposed:
Yes
Planning:

Description

The insistance of sekizai templatetags to be declared in the top template makes authentic theming quite a pain; e.g. you cannot do:

{% extends 'theme/common.html' %}
{% block extra-head %}
{% render_block "css" %}
{% render_block "js" %}
{% endblock %}

Files

Associated revisions

Revision f145e127 (diff)
Added by Benjamin Dauvergne about 9 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

Revision 66815866 (diff)
Added by Benjamin Dauvergne about 9 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

Revision 4c1b2b0f (diff)
Added by Benjamin Dauvergne about 9 years ago

templates: replace use of sekizai by our own template tags

fixes #7206

History

#1

Updated by Benjamin Dauvergne about 9 years ago

Are you sure it does not work or are you quoting the documentation ? It seems to me that the way authentic uses sekizai it should work.

The principle of sekizai is to set a dictionary in a context variable before template rendering and during rendering the dictionnary is filled by subtemplates.

I think that this behaviour is broken if you put the render_block and addtoblock tag in different blocks of the same template as I think you cannot be sure of the ordering of the rendering. But that is not how authentic use sekizai, we begin by rendering subtemplates for the different authentication frontend class, the we pass the rendered blocks to the final template of the login view. Maybe in this case it still works.

#2

Updated by Frédéric Péters about 9 years ago

I tried and it didn't work, for sure. But I set this ticket as low priority, so this can be discussed when we have more time on our hands.

#3

Updated by Benjamin Dauvergne about 9 years ago

  • File 0001-templates-remove-sekizai-tags-and-rename-base.html.patch added
  • Assignee set to Benjamin Dauvergne
  • Target version set to 2.1.20
  • Patch proposed changed from No to Yes
#4

Updated by Frédéric Péters about 9 years ago

The attached patch is about fargo, not authentic.

#5

Updated by Benjamin Dauvergne about 9 years ago

  • File deleted (0001-templates-remove-sekizai-tags-and-rename-base.html.patch)
#7

Updated by Benjamin Dauvergne about 9 years ago

  • Status changed from Nouveau to Résolu (à déployer)
  • % Done changed from 0 to 100
#9

Updated by Benjamin Dauvergne about 9 years ago

  • Status changed from Résolu (à déployer) to Fermé

Also available in: Atom PDF