Project

General

Profile

Bug #11421

validate_idp_list utility test function casts pointer to wrong type

Added by John Dennis over 7 years ago. Updated about 5 years ago.

Status:
Fermé
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
17 June 2016
Due date:
% Done:

100%

Estimated time:
Patch proposed:
Yes
Planning:

Description

validate_idp_list was not using the correct list elements when it
iterated over the known_sp_provided_idp_entries_supporting_ecp list.
It treated them as lists of strings instead of lists of
LassoSamlp2IDPEntry.

Not sure why this ever worked, test would fail only on some
architectures, probably because of the way structs are laid out.

git formatted patch attached.


Files

validate_idp_list_test.patch (2.78 KB) validate_idp_list_test.patch John Dennis, 17 June 2016 09:21 PM
0001-Fix-ecp-test-validate_idp_list.patch (2.97 KB) 0001-Fix-ecp-test-validate_idp_list.patch John Dennis, 17 June 2016 09:56 PM

Associated revisions

Revision fad04ed1 (diff)
Added by John Dennis over 7 years ago

Fix ecp test validate_idp_list() (fixes #11421)

validate_idp_list was not using the correct list elements when it
iterated over the known_sp_provided_idp_entries_supporting_ecp list.
It treated them as lists of strings instead of lists of
LassoSamlp2IDPEntry.

Signed-off-by: John Dennis <>
License: MIT

History

#1

Updated by Benjamin Dauvergne over 7 years ago

Could you provide a patch made with git format-patch please ?

#2

Updated by John Dennis over 7 years ago

Now it's a git formatted patch :-) sorry.

#3

Updated by John Dennis over 7 years ago

  • Status changed from Nouveau to Résolu (à déployer)
  • % Done changed from 0 to 100
#4

Updated by Benjamin Dauvergne about 5 years ago

  • Assignee set to John Dennis
  • Target version set to 2.6.0
#5

Updated by Benjamin Dauvergne about 5 years ago

  • Status changed from Résolu (à déployer) to Fermé

Also available in: Atom PDF