Produits Entr'ouvert » Lasso

Does this patch fix your problem ?

diff --git a/bindings/perl/Makefile.PL b/bindings/perl/Makefile.PL
index 5383d63e..8ac6947d 100644
--- a/bindings/perl/Makefile.PL
+++ b/bindings/perl/Makefile.PL
@@ -2,10 +2,10 @@ use 5;
 use ExtUtils::MakeMaker;

-if (not grep /^LIBS=/, @ARGV) {
-       $LIBS=`pkg-config --libs lasso 2>&1`;
-       die "pkg-config cannot find lasso" if $?;
-}
+#if (not grep /^LIBS=/, @ARGV) {
+#      $LIBS=`pkg-config --libs lasso 2>&1`;
+#      die "pkg-config cannot find lasso" if $?;
+#}

 WriteMakefile(
     NAME              => 'Lasso',

On my computer (Debian sid) it uses the lib from the source not the one from the system with or without these lines.

Thank you Benjamin, but no it does not fix it. I even tried this in Makefile.PL

$LIBS="../../lasso/.libs";

But that didn't work either and since I don't fully understand what is happening in the perl directory I'm concerned something like that might affect what is installed as opposed to what is done during "make check". I think, but I'm not 100% sure that passing $LIBS is what is needed for the installed version (but it probably will work without it).

The problem seems to be in this part of the generated Makefile.perl

test_ : test_dynamic
    $(NOECHO) $(NOOP)

subdirs-test_dynamic :: dynamic pure_all

test_dynamic :: subdirs-test_dynamic
    PERL_DL_NONLAZY=1 $(FULLPERLRUN) "-I$(INST_LIB)" "-I$(INST_ARCHLIB)" $(TEST_FILE)
    PERL_DL_NONLAZY=1 $(FULLPERLRUN) "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness($(TEST_VERBOSE), '$(INST_LIB)', '$(INST_ARCHLIB)')" $(TEST_FILES)

But I haven't done anything with Perl for almost 15 years now and my Perl expertise has atrophied. But I think somewhere in the test_dynmaic target it needs to force the use of the in-tree library. But I don't have enough understanding of how all the moving pieces in MakeMaker work to accomplish this.

John Dennis a écrit :

But I haven't done anything with Perl for almost 15 years now and my Perl expertise has atrophied. But I think somewhere in the test_dynmaic target it needs to force the use of the in-tree library. But I don't have enough understanding of how all the moving pieces in MakeMaker work to accomplish this.

I'm also rusty myself on Perl, I dived deep in the internals when writing the binding but I lost all my knowledge since then. Binding was produced for free software IdP LemonLDAP::NG but they don't have the ressource to maintain it either.

I can't see any way to get the Makefile produced by MakeMaker to use the in-tree version of liblasso just for the unit test. As such this has to be fixed some other way. The best solution I could come up with is to add LD_LIBRARY_PATH=../../.libs inside test.sh which invokes the Perl Makefile to run the test (see below patch). It's less than ideal because it's hardcoded rather than using the configuration produced by autotools. I suppose configure could produce a test.sh from a test.sh.in file but I don't see much value in doing this extra work because quite a bit of the test code already has hardcoded references to ../.libs or ../../.libs. Though some magic I don't yet understand the Java binding has .libs copied into it. Anyway all this is say hardcoding LD_LIBRARY_PATH=../../lasso/.libs in test.sh is no worse than what the other bindings are doing.

diff --git a/bindings/perl/test.sh b/bindings/perl/test.sh
index 907080d1..e2e208cd 100755
--- a/bindings/perl/test.sh
+++ b/bindings/perl/test.sh
@ -1,2 +1,2 @
#!/bin/bash
-make -f Makefile.perl test
+LD_LIBRARY_PATH=../../lasso/.libs make -f Makefile.perl test